Add beta distribution #391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaerVervergaert
commented
Jul 6, 2025
| self.log_a = params[0] | ||
| self.log_b = params[1] | ||
| self.a = np.exp(params[0]) # since params[0] is log(a) | ||
| self.b = np.exp(params[1]) # since params[1] is log(b) |
There was a problem hiding this comment.
Might need to introduce clipping here because sometimes the algorithm overflows and sets value a or b to 0.
alejandroschuler
approved these changes
Jul 7, 2025
|
@BaerVervergaert can you merge master into your PR when you have time? That way we can test 3.13 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Beta distribution (scipy.stats.beta) with loc fixed at zero and scale fixed at one.