Skip to content

deployment: setup namespace github runners #8703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main-v0.14.0
Choose a base branch
from

Conversation

idan-starkware
Copy link
Collaborator

No description provided.

@idan-starkware idan-starkware self-assigned this Aug 20, 2025
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Aug 20, 2025

Copy link

github-actions bot commented Aug 20, 2025

Benchmark movements: No major performance changes detected.

@idan-starkware idan-starkware force-pushed the idan/main-v0.14.0/20-08-2025_namespace_github_runners branch from a20ec02 to f246e88 Compare August 20, 2025 08:12
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 21 files at r1, all commit messages.
Reviewable status: 1 of 21 files reviewed, 1 unresolved discussion (waiting on @idan-starkware)


.github/workflows/blockifier_ci.yml line 53 at r1 (raw file):

jobs:
  test-without-features:
    runs-on: namespace-profile-medium-ubuntu-24-04-amd64;override.cache-tag=${{ github.base_ref }}

what is github.base_ref?
what is the value if I open a PR A over main and then open a PR B over A? will the base_ref of PR B be A or main?

Code quote:

;override.cache-tag=${{ github.base_ref }}

@idan-starkware
Copy link
Collaborator Author

.github/workflows/blockifier_ci.yml line 53 at r1 (raw file):

Previously, dorimedini-starkware wrote…

what is github.base_ref?
what is the value if I open a PR A over main and then open a PR B over A? will the base_ref of PR B be A or main?

The base_ref of PR b will be a

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 21 files reviewed, 1 unresolved discussion (waiting on @idan-starkware)


.github/workflows/blockifier_ci.yml line 53 at r1 (raw file):

Previously, idan-starkware (Idan Shamam) wrote…

The base_ref of PR b will be a

so this is not a good method...
can you inject the contents of scripts/parent_branch.txt into an env var and use it as the cache tag?

@idan-starkware idan-starkware force-pushed the idan/main-v0.14.0/20-08-2025_namespace_github_runners branch from f246e88 to 013f372 Compare August 20, 2025 14:55
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, please add someone from your team to review?
also, what formatter are you using to auto-format the files? we should integrate it into our CI

@dorimedini-starkware reviewed 21 of 21 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @idan-starkware)

@idan-starkware
Copy link
Collaborator Author

.github/workflows/blockifier_ci.yml line 53 at r1 (raw file):

Previously, dorimedini-starkware wrote…

so this is not a good method...
can you inject the contents of scripts/parent_branch.txt into an env var and use it as the cache tag?

Okay, it has been removed. Until we figure this out, we will use the runners without the cache overwrite.

@idan-starkware
Copy link
Collaborator Author

I am using the YAML VSCode plugin by RedHat

Copy link
Collaborator Author

@idan-starkware idan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idan-starkware reviewed 21 of 21 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @phil-starkware)

Copy link
Collaborator

@phil-starkware phil-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@phil-starkware reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants