-
Notifications
You must be signed in to change notification settings - Fork 61
deployment: setup namespace github runners #8703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main-v0.14.0
Are you sure you want to change the base?
deployment: setup namespace github runners #8703
Conversation
Artifacts upload workflows: |
Benchmark movements: No major performance changes detected. |
a20ec02
to
f246e88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 21 files at r1, all commit messages.
Reviewable status: 1 of 21 files reviewed, 1 unresolved discussion (waiting on @idan-starkware)
.github/workflows/blockifier_ci.yml
line 53 at r1 (raw file):
jobs: test-without-features: runs-on: namespace-profile-medium-ubuntu-24-04-amd64;override.cache-tag=${{ github.base_ref }}
what is github.base_ref
?
what is the value if I open a PR A
over main
and then open a PR B
over A
? will the base_ref
of PR B
be A
or main
?
Code quote:
;override.cache-tag=${{ github.base_ref }}
Previously, dorimedini-starkware wrote…
The base_ref of PR b will be a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 21 files reviewed, 1 unresolved discussion (waiting on @idan-starkware)
.github/workflows/blockifier_ci.yml
line 53 at r1 (raw file):
Previously, idan-starkware (Idan Shamam) wrote…
The base_ref of PR b will be a
so this is not a good method...
can you inject the contents of scripts/parent_branch.txt
into an env var and use it as the cache tag?
f246e88
to
013f372
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me, please add someone from your team to review?
also, what formatter are you using to auto-format the files? we should integrate it into our CI
@dorimedini-starkware reviewed 21 of 21 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @idan-starkware)
Previously, dorimedini-starkware wrote…
Okay, it has been removed. Until we figure this out, we will use the runners without the cache overwrite. |
I am using the YAML VSCode plugin by RedHat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idan-starkware reviewed 21 of 21 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @phil-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phil-starkware reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
No description provided.