apollo_dashboard: add storage section #8712
Open
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Artifacts upload workflows: |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Benchmark movements: tree_computation_flow performance improved 😺 tree_computation_flow time: [33.632 ms 33.785 ms 33.931 ms] change: [-4.8728% -3.1687% -1.7111%] (p = 0.00 < 0.05) Performance has improved. |
ayeletstarkware
force-pushed
the
ayelet/dashboard/add-storage-section
branch
from
26da3bb to
7d7e230
Compare
ayeletstarkware
force-pushed
the
ayelet/dashboard/add-storage-section
branch
from
7d7e230 to
3e95346
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 7 files reviewed, all discussions resolved
crates/apollo_dashboard/Cargo.toml line 32 at r1 (raw file):
apollo_metrics.workspace = true apollo_state_sync_metrics.workspace = true apollo_storage.workspace = true
Could add this in the next pr without the adding/removing the machete section, no?
Code quote:
apollo_storage.workspace = true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.