Skip to content
This repository was archived by the owner on Sep 10, 2021. It is now read-only.

yml parser exception fix #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nazarblch
Copy link

I have tested this project on parsing real yml files. In many cases it throws exception because offers and shop objects in yml contain some extra fields, that are not in kwargs of AbstractOffer or Shop.

  1. I have fix this exception by creating method clear_args that filters the extra fields.

  2. Some date values causes exception because of wrong format. I have added additional formal DATE_FORMAT_SHORT = "%Y-%m-%d".

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020

Codecov Report

Merging #34 into master will decrease coverage by 0.17%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #34      +/-   ##
===========================================
- Coverage   100.00%   99.82%   -0.18%     
===========================================
  Files           22       22              
  Lines         1147     1164      +17     
===========================================
+ Hits          1147     1162      +15     
- Misses           0        2       +2     
Impacted Files Coverage Δ
yandex_market_language/models/feed.py 93.75% <60.00%> (-6.25%) ⬇️
yandex_market_language/models/abstract.py 100.00% <100.00%> (ø)
yandex_market_language/models/age.py 100.00% <100.00%> (ø)
yandex_market_language/models/condition.py 100.00% <100.00%> (ø)
yandex_market_language/models/currency.py 100.00% <100.00%> (ø)
...et_language/models/fields/enable_auto_discounts.py 100.00% <100.00%> (ø)
yandex_market_language/models/gift.py 100.00% <100.00%> (ø)
yandex_market_language/models/offers.py 100.00% <100.00%> (ø)
yandex_market_language/models/parameter.py 100.00% <100.00%> (ø)
yandex_market_language/models/promo.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bae502...fbde10f. Read the comment docs.

@stefanitsky stefanitsky added bug Something isn't working good first issue Good for newcomers labels Jul 25, 2020
@stefanitsky stefanitsky linked an issue Jul 25, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parsing seller_warranty tag
3 participants