-
Notifications
You must be signed in to change notification settings - Fork 52
feat(mcp): implement http transport support #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MCP server chore(dependencies): add pytest-asyncio to development dependencies chore(smithery): update main server to handle query parameter configuration and improve logging chore(vscode): add task for running pytest tests in VSCode
… handling and add tests
…using FastMCP's http_app()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for a new HTTP-based transport mode (streamable-http) by integrating FastMCP’s HTTP server, updating configuration, CLI, startup logic, and tasks.
- Introduces
streamable-httpas a transport option in schemas, loaders, CLI, and interactive prompts - Updates
main.pyto launch and report the HTTP server endpoint when usingstreamable-http - Switches FastMCP imports to the top‐level
fastmcppackage, adjusts dependencies, and adds related dev dependencies; removes deprecatedsmithery.yaml
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| smithery.yaml | Removed outdated Smithery config for Docker-based MCP server |
| pyproject.toml | Added fastmcp; removed httpx and mcp[cli]; updated dev deps |
| main.py | Implemented HTTP transport branch and prompt updates |
| linkedin_mcp_server/tools/person.py | Switched import to fastmcp |
| linkedin_mcp_server/tools/job.py | Switched import to fastmcp |
| linkedin_mcp_server/tools/company.py | Switched import to fastmcp |
| linkedin_mcp_server/server.py | Switched import to fastmcp; reordered tool registrations |
| linkedin_mcp_server/drivers/chrome.py | Reordered imports; added get_credentials; reordered stdlib/third-party |
| linkedin_mcp_server/config/secrets.py | Fixed import ordering |
| linkedin_mcp_server/config/schema.py | Extended ServerConfig with HTTP fields and new transport |
| linkedin_mcp_server/config/loaders.py | Added env/arg parsing for host, port, path, and toggles |
| linkedin_mcp_server/cli.py | Reordered imports |
| .vscode/tasks.json | Added HTTP run task; adjusted default task flags |
Comments suppressed due to low confidence (1)
.vscode/tasks.json:135
- There’s now a trailing comma after the last task entry, which makes the JSON invalid. Please remove the comma to restore valid JSON syntax.
},
stickerdaniel
added a commit
that referenced
this pull request
Jul 4, 2025
This reverts commit 0b8c73d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…using FastMCP's http_app()