Skip to content

endpoint operator: avoid duplicate controller name #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jacobbaungard
Copy link
Contributor

This seems to crash otherwise with later versions of the controller-runtime.

ACM-23542

This seems to crash otherwise with later versions of the
controller-runtime.

ACM-23542

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jacobbaungard,philipgough]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The CI images annotation were only added to some of the MCO specs,
however we have a few different ones, and it looks like we usually use
the custom-certs one in at least some CI tests.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Aug 21, 2025
Copy link

openshift-ci bot commented Aug 21, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Aug 21, 2025

@jacobbaungard: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kind 7a63a09 link true /test e2e-kind
ci/prow/test-e2e 7a63a09 link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants