Skip to content

SSPROD-58066 - enhance: explicitly define project for ing sink #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

SSPROD-58066 - enhance: explicitly define project for ing sink #71

merged 1 commit into from
Jun 17, 2025

Conversation

jose-pablo-camacho
Copy link
Contributor

@jose-pablo-camacho jose-pablo-camacho requested a review from a team as a code owner June 17, 2025 15:39
ravinadhruve10
ravinadhruve10 approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the same fix needed for org level sink?

@jose-pablo-camacho
Copy link
Contributor Author

@ravinadhruve10 - I checked on the Org level sink and looks like there's not argument reference to project_id: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/logging_organization_sink#argument-reference

So looks like this is on an org level

@m-shah
Copy link

m-shah commented Jun 17, 2025

Module verification job:
Org deployment failed due to a unrelated issue that we are debugging. Single deployment worked.

@jose-pablo-camacho jose-pablo-camacho merged commit 7850537 into master Jun 17, 2025
8 checks passed
@jose-pablo-camacho jose-pablo-camacho deleted the SSPROD-58066/enahnce/define-project-ingestion-sink branch June 17, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinadhruve10 ravinadhruve10 ravinadhruve10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jose-pablo-camacho @m-shah @ravinadhruve10