-
Notifications
You must be signed in to change notification settings - Fork 51
Falcon stdc++17 #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Falcon stdc++17 #200
Conversation
The VERSION is still 3.6, we should change that. The "make check" and "make bench5" didn't' show any issues, but I found a small difference in the final result of another test done, two ways:
I ran this on Ubuntu 22.04 with g++ 11.4. Will also test with a g++ 14 |
For the diferrences, they are very small. It can be the result of the compilation with "-std=c++11", plus some modifications. It does not seem to be critical. |
Btw, to be compatible with c++17, I had to remove some "register" keyword, which could be why there are some tiny differences in the results. |
version really is a MUST! Although the differences are small, the regression test is being run with "make check" does not show any differences. Quite puzzling. Regression is on a 1024 plummer, to tstop=2, and the Etot shows a difference in the 9th decimal instead of the 8th. |
In this branch, the Dehnen code (falcON) is now compatible with the C++17 standard. When compiling, there are practically no more warnings, both with g++ (Linux) and with clang++ on Mac Intel/ARM.
In the make.gcc and make.clang configurations files, I have forced the C++11 standard because some compilers are not yet C++17 compatible.