Skip to content

fixed time filter not working when date is empty #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2025
Merged

fixed time filter not working when date is empty #1026

merged 3 commits into from
Feb 23, 2025

Conversation

YuDavidCao
Copy link
Collaborator

GitHub Issues addressed

  • This PR closes

What I did

  • fixed time filter not working when no excluded dates are selected

Screenshots

  • Before
    image

  • After
    image

Testing

  • A brief explanation of tests done/written or how reviewers can test your work

Questions/Discussions/Notes

@barrett-ruth
Copy link
Contributor

@YuDavidCao who is supervising this? Who needs to review this?

@barrett-ruth
Copy link
Contributor

Is this still relevant?

@YuDavidCao
Copy link
Collaborator Author

Yeah still relevant, should just be a quick fix to the search functionality. I just kinda noticed it and patched it. I tagged AJ and Jay because they are like overseeing enhanced-search so.

@barrett-ruth
Copy link
Contributor

🐐

Copy link
Member

@ajnye ajnye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajnye ajnye merged commit d6dfdda into dev Feb 23, 2025
3 checks passed
chaizhang pushed a commit that referenced this pull request Aug 10, 2025
fixed time filter not working when date is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants