Skip to content

Empty url #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2,911 commits into from
Closed

Empty url #1040

wants to merge 2,911 commits into from

Conversation

YuDavidCao
Copy link
Collaborator

GitHub Issues addressed

  • This PR closes

What I did

  • cleaned up url parameter when no according search filter is applied

Screenshots

  • Before
    image

  • After
    image

Testing

  • A brief explanation of tests done/written or how reviewers can test your work

Questions/Discussions/Notes

barrett-ruth and others added 30 commits November 3, 2024 17:10
@barrett-ruth
Merge pull request #925 from thecourseforum/fix-fontawesome
64a6ef0 
Revert Fontawesome kit
@barrett-ruth @artiehumphreys
refactor(search): begin indices
8630012
@artiehumphreys
fix: proper trigram search over instructor model
e2ad688
@artiehumphreys
fix: increased similarity and better scoring
f00e982
@artiehumphreys
feat(instructors): improved logic for finding max similarity given a …
99b2a7d 
…search
@artiehumphreys
fix: added new index for course searches
26f1999
@artiehumphreys
fix: lint
b188a1f
@artiehumphreys
fix(tests): replace full_name() method with full_name instance variable
4bb2e29
@barrett-ruth
Merge pull request #912 from thecourseforum/search/refactor
5f377e8 
Add Indices to Search
@artiehumphreys
fix: improved trigram search for courses
5768c4a
@artiehumphreys
fix(search): simplified search and new index for course title
4871cd4
@barrett-ruth
feat: refactor search to not use elasticsearch api
dfe411b
@barrett-ruth
fix(search): cleanup mean()
32cb402
@barrett-ruth
fix(search): only pass necessary data to template
5be0f02
@barrett-ruth
chore: remove uncessary pprint import
3da3b4f
@barrett-ruth
fix(style): prefer comprehensions to fp
1e210e3
@barrett-ruth
Merge branch 'dev' into issue-826-bar_chart_overflow
da73883
@barrett-ruth
Merge pull request #880 from thecourseforum/issue-826-bar_chart_overflow
97b352d 
Padded Bar Chart Display
@barrett-ruth
Merge branch 'dev' into rip-tino
35c12f2
@barrett-ruth
Merge pull request #875 from thecourseforum/rip-tino
373f2d9 
feat(about): make tino an alum
@barrett-ruth
Merge branch 'dev' into search/fetch_courses
c5b18b6
@artiehumphreys
fix(search): add space for handling mnemonic number searches without …
945362d 
…a space
@artiehumphreys
fix: comments
b178d94
@barrett-ruth
refactor(search): code cleanups
3ecc239
@artiehumphreys
fix(search): improved threshold and lint
76f26f5
@barrett-ruth
Merge pull request #926 from thecourseforum/search/fetch_courses
d14cb7e 
Search/fetch courses
@barrett-ruth
Merge branch 'dev' into search/refactor
1e1ca98
@barrett-ruth
fix(search): refactor + simplify search logic
2804a65
@barrett-ruth
fix(lint): remove unused arg
aa56137
@artiehumphreys
fix: readability
48794f1
ajnye and others added 23 commits February 17, 2025 19:11
@ajnye
Merge pull request #1016 from thecourseforum/enhanced_search_brian
af83dda 
Enhanced search beacon/tooltip
@Jay-Lalwani
tooltip cleanup
0d10d4c
@barrett-ruth
Merge pull request #1021 from thecourseforum/update-envexample
06ba029 
update .env.example
@barrett-ruth
Merge branch 'dev' into mvp-enhanced-search
4b30202
@barrett-ruth
Merge pull request #998 from thecourseforum/mvp-enhanced-search
75d668c 
MVP for Enhanced Search
@barrett-ruth
Merge pull request #1022 from thecourseforum/master
63c47fd 
Master
@ajnye
Fixed search not working due to new filter system
1df08af
@YuDavidCao
fixed time filter not working when date is empty
3ebb290
@ajnye
Fixed results returning more than 15 courses
5dea002
@alex-yung-github
Updated tooltips
555dfd8
@alex-yung-github
Merge branch 'dev' into issue-1017-pie-chart-gpa-label
414a07c
@alex-yung-github
lint fixes
ec8b025
@alex-yung-github
lint fixes
68ed436
@ajnye
Merge branch 'dev' into time-filter-fix
3a97d31
@ajnye
Merge pull request #1033 from thecourseforum/issue-1017-pie-chart-gpa…
a0bebd2 
…-label

Resolve Issue 1017: pie chart gpa label
@ajnye
Merge branch 'dev' into time-filter-fix
9a1eb26
@Jay-Lalwani
limit filter results to 15
7e9623b
@ajnye
Merge pull request #1026 from thecourseforum/time-filter-fix
87854a9 
fixed time filter not working when date is empty
@ajnye
Merge pull request #1036 from thecourseforum/limit-filter-results
758a603 
limit filter results to 15
@visva-murali
fix: seperated marketing and design teams on the about page
d182bcb
@YuDavidCao
emptied according search param from url when no filters are applied
d47a4ea
@alex-yung-github
Merge pull request #1037 from thecourseforum/unmerge-marketing-design
33c6a01 
fix: seperated marketing and design teams on the about page
@YuDavidCao
Merge branch 'dev' into empty-url
4af989c
@YuDavidCao YuDavidCao requested a review from Jay-Lalwani March 2, 2025 17:37
@YuDavidCao YuDavidCao requested a review from ajnye March 2, 2025 20:02
@barrett-ruth
Copy link
Contributor

@ajnye

@ajnye ajnye closed this Apr 5, 2025
@barrett-ruth barrett-ruth deleted the empty-url branch April 7, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-Lalwani Jay-Lalwani Jay-Lalwani approved these changes

@ajnye ajnye Awaiting requested review from ajnye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.