Bug: Missing average rating from course instructor card #1125

artiehumphreys · 2025-07-26T21:13:16Z

See #1124.

Before

After

Before

After

Summary by CodeRabbit

New Features
- Instructor ratings are now displayed for each instructor on the course page.
Style
- Improved consistency in import organization.

…ng for a course

coderabbitai · 2025-07-26T21:13:25Z

Walkthrough

The import statements in the tcf_website/views/browse.py file were reordered for consistency, particularly grouping pagination and Django ORM-related imports. Within the course_view function, each instructor is now assigned a rating attribute using their average_rating_for_course(course) method, ensuring instructor ratings are available during course page rendering.

Changes

File(s)	Change Summary
tcf_website/views/browse.py	Reordered imports for clarity; added assignment of instructor ratings in `course_view` loop.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related issues

Bug: Missing average rating data within course card for instructor #1124: Adds assignment of each instructor's average rating within course_view, directly addressing missing average rating data.

Poem

🐇
In the warren of code where the courses reside,
Instructor ratings now hop in with pride.
Imports in order, all neat and precise,
Browsing for knowledge just got more nice.
With every review, the forum grows bright—
A carrot for coders, and bunnies delight!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8c0ccd and 367a7ab.

📒 Files selected for processing (1)

tcf_website/views/browse.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: django
GitHub Check: pylint

🔇 Additional comments (2)

tcf_website/views/browse.py (2)

10-12: Good import organization for better readability.

The import statements have been properly grouped for consistency - pagination imports, Django ORM imports, and function imports are now logically organized together.

273-274: Excellent fix for the missing average rating bug.

This addition properly assigns the course-specific average rating to each instructor, making it available for display on the course instructor card. The placement within the instructor processing loop is correct and directly addresses the reported issue.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 1124-missing-average-rating

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

@artiehumphreys

Docstrings generation was requested by @artiehumphreys. * #1125 (comment) The following files were modified: * `tcf_website/views/browse.py`

coderabbitai · 2025-07-26T21:14:21Z

Note

Generated docstrings for this pull request at #1126

Jay-Lalwani

good catch

fix(browse): give instructors rating attribute for their average rati…

367a7ab

…ng for a course

artiehumphreys requested a review from Jay-Lalwani July 26, 2025 21:13

artiehumphreys added the Bug Something isn't working label Jul 26, 2025

coderabbitai bot added a commit that referenced this pull request Jul 26, 2025

📝 Add docstrings to 1124-missing-average-rating

5882036

Docstrings generation was requested by @artiehumphreys. * #1125 (comment) The following files were modified: * `tcf_website/views/browse.py`

coderabbitai bot mentioned this pull request Jul 26, 2025

📝 Add docstrings to 1124-missing-average-rating #1126

Closed

Jay-Lalwani approved these changes Jul 26, 2025

View reviewed changes

Jay-Lalwani merged commit 811a6ba into dev Jul 27, 2025
4 checks passed

Copilot AI mentioned this pull request Jul 27, 2025

Merge dev branch into master - Instructor rating fix and database improvements #1127

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bug: Missing average rating from course instructor card #1125

Bug: Missing average rating from course instructor card #1125

Uh oh!

artiehumphreys commented Jul 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 26, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot commented Jul 26, 2025

Uh oh!

Jay-Lalwani left a comment

Uh oh!

Uh oh!

Uh oh!

Bug: Missing average rating from course instructor card #1125

Bug: Missing average rating from course instructor card #1125

Uh oh!

Conversation

artiehumphreys commented Jul 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Before

After

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot commented Jul 26, 2025

Uh oh!

Jay-Lalwani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

artiehumphreys commented Jul 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)