chore: upgrade flash-list to v2 #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the @shopify/flash-list library from version 1.7.6 to version 2.0.0, which requires removing deprecated properties and updating type definitions to maintain compatibility.
- Removes
estimatedItemSizeprop from FlashList components (deprecated in v2) - Updates
ViewTokentype definition to include generic type parameter - Improves null safety handling for
contentContainerStyleprop
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates flash-list dependency to v2.0.0 |
| src/components/app/index/Overview/index.tsx | Removes estimatedItemSize, updates ViewToken types, and inlines width calculation |
| src/components/VerticalList/index.tsx | Removes estimatedItemSize and adds null safety for contentContainerStyle |
| src/components/List/index.tsx | Removes estimatedItemSize prop |
Comment on lines
+83
to
+85
| ...(typeof contentContainerStyle === 'object' && contentContainerStyle | ||
| ? contentContainerStyle | ||
| : {}), |
There was a problem hiding this comment.
[nitpick] The null safety check is overly complex. Since contentContainerStyle is likely typed as an optional object, a simpler check like ...(contentContainerStyle || {}) would be more readable and achieve the same result.
Suggested change
| ...(typeof contentContainerStyle === 'object' && contentContainerStyle | |
| ? contentContainerStyle | |
| : {}), | |
| ...(contentContainerStyle || {}), |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.