-
Notifications
You must be signed in to change notification settings - Fork 874
Coinbase: Update exchange implementation #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cranktakular
wants to merge
176
commits into
thrasher-corp:master
Choose a base branch
from
cranktakular:coinbase_api_revamp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8,990
−3,932
Open
Changes from 165 commits
Commits
Show all changes
176 commits
Select commit
Hold shift + click to select a range
a006163
Slight enhance of Coinbase tests
cranktakular 074f367
Merge branch 'master' into coinbase_api_revamp
cranktakular bd9f2dd
Coinbase revamp; CreateReport is still WIP
cranktakular 25fcd2e
More coinbase improvements; onto sandbox testing
cranktakular 5d3fd99
Coinbase revamp continues
cranktakular 3aca36b
Coinbase revamp continues
cranktakular f58b76d
Merge branch 'coinbase_api_revamp' of github.com:cranktakular/gocrypt…
cranktakular eded160
Coinbasepro revamp is ceaseless
cranktakular 5a0ba23
Coinbase revamp, starting on advanced trade API
cranktakular 88e6713
Coinbase Advanced Trade Starts in Ernest
cranktakular aa2efef
Coinbase revamp stage wrapper
cranktakular 3560599
Merge branch 'master' into coinbase_api_revamp
cranktakular 4593828
Coinbase wrapper coherence continues
cranktakular a8cae40
Coinbase wrapper continues writhing
cranktakular 0564e45
Coinbase wrapper & codebase cleanup
cranktakular 4f5ccb5
Coinbase updates & wrap progress
cranktakular 9a6c7e6
More Coinbase wrapper progress
cranktakular 2896b3e
Wrapper is wrapped, kinda
cranktakular ffb43d8
Test & type checking
cranktakular 7dd4589
Coinbase REST revamp finished
cranktakular 6d7ac5f
Merge branch 'master' into coinbase_api_revamp
cranktakular 2881841
Post-merge fix
cranktakular 2166886
WS revamp begins
cranktakular 35eda67
WS Main Revamp Done?
cranktakular 6ac86cd
CB websocket tidying up
cranktakular cfe6e11
Coinbase WS wrapperupperer
cranktakular 2f770d5
Coinbase revamp done??
cranktakular 3e54528
Merge branch 'master' into coinbase_api_revamp
cranktakular 2f05c05
Linter progress
cranktakular 005af4a
Continued lint cleanup
cranktakular 2b5df7c
Further lint cleanup
cranktakular 93d6722
Increased lint coverage
cranktakular 529f7f3
Does this fix all sloppy reassigns & shadowing?
cranktakular 8bb2561
Undoing retry policy change
cranktakular 5f813e3
Documentation regeneration
cranktakular c7d7ac2
Coinbase code improvements
cranktakular 8cdc78a
Providing warning about known issue
cranktakular 19245e3
Merge branch 'master' into coinbase_api_revamp
cranktakular 79ac205
Updating an error to new format
cranktakular e073757
Making gocritic happy
cranktakular a65fc38
Review adherence
cranktakular 254efe7
Merge branch 'master' into coinbase_api_revamp
cranktakular 14ab490
Endpoints moved to V3 & nil pointer fixes
cranktakular bee2878
Removing seemingly superfluous constant
cranktakular 1d51a2e
Glorious improvements
cranktakular 90e20e1
Merge master, resolving conflict
cranktakular 4d1afc2
Removing unused error
cranktakular 55596d8
Partial public endpoint addition
cranktakular 343052b
Slight improvements
cranktakular ea43046
Wrapper improvements; still a few errors left in other packages
cranktakular 6dbb243
A lil Coinbase progress
cranktakular f3fc162
Merge with master + improvements
cranktakular a5a3bad
Json cleaning
cranktakular 742b21e
Lint appeasement
cranktakular 71e0fa5
Config repair
cranktakular 01ccd01
Config fix (real)
cranktakular 228c3ba
Merge master maybe?
cranktakular 91d4b24
Little fix
cranktakular 75425fd
New public endpoint incorporation
cranktakular 44ff400
Merge branch 'master' into coinbase_api_revamp
cranktakular eec8a5d
Additional fixes
cranktakular bbcc27b
Improvements & Appeasements
cranktakular e8a06e8
LineSaver
cranktakular d70d599
Merge branch 'master' into coinbase_api_revamp
cranktakular 4b79d3f
Merge branch 'master' into coinbase_api_revamp
cranktakular d699631
Additional fixes
cranktakular 0f18f8c
Another fix
cranktakular c0aa9a4
Fixing picked nits
cranktakular ac98019
Quick fixies
cranktakular 8e1b87b
Merge branch 'master' into coinbase_api_revamp
cranktakular e372aea
Lil fixes
cranktakular d384ec2
Subscriptions: Add List.Enabled
gbjk 9205394
CoinbasePro: Add subscription templating
gbjk 13a3faf
fixup! CoinbasePro: Add subscription templating
gbjk 62c48af
fixup! CoinbasePro: Add subscription templating
gbjk 1dac1c1
Merge pull request #3 from gbjk/feature/coinbase_sub_conf_v2
cranktakular 2e814d5
Comment fix
cranktakular 57567f8
Merge branch 'coinbase_api_revamp' of github.com:cranktakular/gocrypt…
cranktakular 02b88c4
Merge branch 'master' into coinbase_api_revamp
cranktakular 06f8a6a
Subsequent fixes
cranktakular 0e0c09e
Merge branch 'master' into coinbase_api_revamp
cranktakular 9edf0c9
Issues hopefully fixed
cranktakular 7e30794
Lint fix
cranktakular 242efa3
Merge branch 'master' into coinbase_api_revamp
cranktakular 329e039
Glorious fixes
cranktakular d797e69
Json formatting
cranktakular 9925c88
ShazNits
cranktakular c88b057
(L/N)i(n/)t
cranktakular 0eeb73c
Merge master and minor fixes
cranktakular 4acb64d
Merge master and minor fixes
cranktakular 5974421
Adding a test
cranktakular 2a90b5d
Tiny test improvement
cranktakular 3f6976c
Merge branch 'master' into coinbase_api_revamp
cranktakular 3eb15db
Template patch testing
cranktakular 38f2765
Fixes
cranktakular 2cc9d0c
Merge branch 'master' into coinbase_api_revamp
cranktakular 2fd8bb1
Further shaznits
cranktakular 1229376
Merge branch 'master' into coinbase_api_revamp
cranktakular a4252ec
Lint nit
cranktakular ff6ce5f
JWT move and other fixes
cranktakular 19fbf09
Small nits
cranktakular e1ba339
Shaznit, singular
cranktakular 59a9d7b
Merge branch 'master' into coinbase_api_revamp
cranktakular 80cb272
Post-merge fix
cranktakular eba7717
Merge branch 'master' into coinbase_api_revamp
cranktakular 74f47d0
Post-merge fixes
cranktakular 52f1089
Typo fix
cranktakular 0b3de87
Some glorious nits
cranktakular 2350629
Merge branch 'master' into coinbase_api_revamp
cranktakular 3447fea
Required changes
cranktakular 4820d65
Stop going
cranktakular a316c25
Alias attempt
cranktakular 2e35113
Alias fix & test cleanup
cranktakular 50a599b
Merge branch 'master' into coinbase_api_revamp
cranktakular 5cc49e8
Test fix
cranktakular 0c85038
GetDepositAddress logic improvement
cranktakular 2de2256
Status update: Fixed
cranktakular ea87268
Lint fix
cranktakular 944b975
Merge branch 'master' into coinbase_api_revamp
cranktakular 00d42b6
Merge branch 'master' into coinbase_api_revamp
cranktakular e33a655
Happy birthday to PR 1480
cranktakular 5f8f5b5
Merge branch 'master' into coinbase_api_revamp
cranktakular 7d9789e
Cleanups
cranktakular fb0fe06
Necessary nit corrections
cranktakular 7409cad
Merge branch 'master' into coinbase_api_revamp
cranktakular 5de9d7f
Fixing sillybug
cranktakular d3bdad0
Merge branch 'master' into coinbase_api_revamp
cranktakular 0d05b24
Quick merge master, worth double-checking test changes I rejected
cranktakular 11ba1e8
As per request
cranktakular df694fd
Merge branch 'master' into coinbase_api_revamp
cranktakular d5b9bf3
Programming progress
cranktakular 895efc8
Order fixes
cranktakular 98ca051
Merge branch 'master' into coinbase_api_revamp
cranktakular 7764b9d
Further fixies
cranktakular e9aeb33
Test fix
cranktakular 51103b7
Pre-merge fixes
cranktakular 1c5b1ed
Merge & fixes
cranktakular ecbbbc0
Merge branch 'master' into coinbase_api_revamp
cranktakular 4bf0d1f
More shaznits
cranktakular 64cfc62
Context
cranktakular 13d8746
Sonic error handling
cranktakular bb68ccf
Import fix
cranktakular 5fc1bbd
Better Sonic error handling
cranktakular 404cda8
Perfect Sonic error handling?
cranktakular d4eaf58
F purge
cranktakular 10e0212
Coinbase improvements
cranktakular 7743a7f
API Update Conformity
cranktakular ae47e3d
Merge branch 'master' into coinbase_api_revamp
cranktakular cdc2447
Coinbase continuation
cranktakular 18b134c
Merge and associated fixes
cranktakular c3d7edb
Coinbase order improvements
cranktakular 639d7db
Coinbase order improvements
cranktakular a8d41ea
CreateOrderConfig improvements
cranktakular 6a408b7
Merge branch 'master' into coinbase_api_revamp
cranktakular 82e9215
Managing API updates
cranktakular f2707ac
Coinbase API update progression
cranktakular 3fa8da5
jwt rename
cranktakular 511720e
Comment link fix
cranktakular b2f5a83
Coinbase v2 cleanup
cranktakular 9396618
Merge branch 'master' into coinbase_api_revamp
cranktakular 3dcd419
Post-merge fixes
cranktakular 04d2218
Review fixes
cranktakular c008869
GK's suggestions
cranktakular c2726b9
Merge branch 'master' into coinbase_api_revamp
cranktakular 330e848
Linter fix
cranktakular 2e685ce
Minor gbjk fixes
cranktakular 0411e46
Nit fixes
cranktakular 6651cda
Merge branch 'master' into coinbase_api_revamp
cranktakular 587eefd
Merge fix
cranktakular 2e5b6fe
Lint fixes
cranktakular 1ff7838
Merge branch 'master' into coinbase_api_revamp
cranktakular 8a1a020
Coinbase rename stage 1
cranktakular bd69baa
Coinbase rename stage 2
cranktakular fce9f4e
Coinbase rename stage 3
cranktakular a13ce5b
Coinbase rename stage 4
cranktakular b16b543
Coinbase rename final fix
cranktakular File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.