-
Notifications
You must be signed in to change notification settings - Fork 874
cmd/exchange_template: Update wrapper template, improve documentation #2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes grammatical errors and improves documentation across exchange wrapper templates and documentation files. The main purpose is to correct a repeated typo where comments incorrectly stated "Submits an order and the exchange" instead of "Submits an order to the exchange".
Key changes:
- Corrects grammatical error in order submission comments across all exchange documentation
- Updates wrapper template with improved pair format examples
- Modernizes documentation references and terminology
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
Multiple exchange README.md files | Fixed grammatical error in order submission comment |
Multiple exchange template files | Fixed same grammatical error in documentation templates |
cmd/exchange_template/wrapper.tmpl | Updated pair format examples with delimiters |
docs/ADD_NEW_EXCHANGE.md | Updated GitHub link and improved code examples |
cmd/documentation/root_templates/root_readme.tmpl | Changed "Streaming API" to "Websocket" in table header |
README.md | Updated exchange support table header and contributor statistics |
CONTRIBUTORS | Updated contributor ordering |
@@ -319,7 +305,7 @@ Modify existing constants or create new ones to define the API URL paths, as app | |||
apiURL = "https://api.binance.com" | |||
``` | |||
|
|||
Create a get function in `rest.go` file and unmarshall the data in the created type: | |||
Create a get function in the `rest.go` file and unmarshal the data in the created type: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'unmarshall' should be 'unmarshal' (single 'l').
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is why I am changing it Copilot sir.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2009 +/- ##
==========================================
- Coverage 39.78% 39.78% -0.01%
==========================================
Files 433 433
Lines 172030 172030
==========================================
- Hits 68446 68437 -9
- Misses 96446 96457 +11
+ Partials 7138 7136 -2 🚀 New features to boost your workflow:
|
PR Description
Fixing some oddities I encountered when implementing Bitget.
There are some other oddities I've spotted that I'm not equipped to handle:
Type of change
How has this been tested
No tests were done, as this was largely changing documentation, with biggest changes being minor functional template tweaks.
Checklist