Add default-off option everything in a parallel worker #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgreen42
reviewed
Jun 20, 2025
tjgreen42
reviewed
Jun 20, 2025
| }; | ||
|
|
||
| let pcxt = pg_sys::CreateParallelContext(EXTENSION_NAME, PARALLEL_BUILD_MAIN, workers); | ||
| let snapshot = if is_concurrent { |
There was a problem hiding this comment.
Do we have any tests today that use CREATE INDEX CONCURRENT?
tjgreen42
reviewed
Jun 20, 2025
syvb
added a commit
that referenced
this pull request
Jun 20, 2025
The `timescaledev/rust-builder` is outdated, and we don't need it anyways because everything in it we need is in the base GH Actions image. This fixes the CI failure in #240 stemming from this action's Docker image using an outdated Rust compiler. It also speeds up the check significantly, because we don't need to wait for the Docker image to be setup anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a precursor to a latter PR to support parallel index build.