TINY-11824: Upgrade plugin to support eslint V9 and flat config #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza0867
requested review from
spocke,
TheSpyder,
ltrouton,
jscasca,
kemister85 and
tiny-stale-bot
hamza0867
requested review from
a team,
lorenzo-pomili,
HAFRMO and
michalnieruchalski-tiugo
and removed request for
a team
spocke
approved these changes
Apr 24, 2025
spocke
reviewed
Apr 24, 2025
lorenzo-pomili
approved these changes
Apr 28, 2025
TheSpyder
reviewed
Apr 29, 2025
Comment on lines
+59
to
+61
| { messageId: 'noDirectEditorEvents' }, | ||
| { messageId: 'noDirectEditorEvents' }, | ||
| { messageId: 'noDirectEditorEvents' } |
There was a problem hiding this comment.
I thought I had submitted this, but github uses the same colour for pending and outdated comments so I didn't notice my request was not blocking merge 🤦
Not sure what to do with this now. New ticket I suppose?
Even if this is how eslint works now, messageId tests are only an acceptable replacement if you also verify that the IDs map to the messages we expect
- Add ID to console message checks for each of these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-11824
Description of Changes:
Pre-checks:
Tests have been added (if applicable)