Private CloudFront Distribution #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alukach
force-pushed
the
feature/private-cloudfront-distribution
branch
from
64f6c37 to
e9a72e3
Compare
|
@nathanielrindlaub In 777a77b, I've moved the logic of creating our keys to a custom resource lambda function1 Footnotes |
nathanielrindlaub
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
@alukach this looks great. Thanks for moving the key generation into CF via the Lambda custom resource. I did not know you could do that! Super cool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pursuit of tnc-ca-geo/animl-api#38, I propose that we create a private cloudfront distribution alongside the current cloudfront distribution to simplify the transition to requiring signed-urls/signed-cookies.
This PR:
OriginAccessIdentity