Skip to content

ci: add arm emulator build in github actions #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

vdovhanych
Copy link
Member

No description provided.

@vdovhanych vdovhanych force-pushed the gh-actions-arm-emulator-builds branch 2 times, most recently from b57a20e to edf7517 Compare July 30, 2024 08:15
@mmilata
Copy link
Member

mmilata commented Jul 30, 2024

We had hardcoded x86 target for bootloader emulator, please apply following patch:

diff --git a/core/SConscript.bootloader_emu b/core/SConscript.bootloader_emu
index fb254c8765..a9083f8c6a 100644
--- a/core/SConscript.bootloader_emu
+++ b/core/SConscript.bootloader_emu
@@ -256,7 +256,7 @@ cmake_gen = env.Command(
 # Rust library
 #
 
-RUST_TARGET = 'x86_64-unknown-linux-gnu'
+RUST_TARGET = os.popen("rustc -vV | sed -n 's/host: //p'").read().strip()
 RUST_LIB = 'trezor_lib'
 
 if ARGUMENTS.get('TREZOR_EMULATOR_DEBUGGABLE', '0') == '1':

@vdovhanych
Copy link
Member Author

We had hardcoded x86 target for bootloader emulator, please apply following patch:

diff --git a/core/SConscript.bootloader_emu b/core/SConscript.bootloader_emu
index fb254c8765..a9083f8c6a 100644
--- a/core/SConscript.bootloader_emu
+++ b/core/SConscript.bootloader_emu
@@ -256,7 +256,7 @@ cmake_gen = env.Command(
 # Rust library
 #
 
-RUST_TARGET = 'x86_64-unknown-linux-gnu'
+RUST_TARGET = os.popen("rustc -vV | sed -n 's/host: //p'").read().strip()
 RUST_LIB = 'trezor_lib'
 
 if ARGUMENTS.get('TREZOR_EMULATOR_DEBUGGABLE', '0') == '1':

thanks, it's working with this.

@vdovhanych vdovhanych force-pushed the gh-actions-arm-emulator-builds branch from a0d8d1e to 78bfc06 Compare August 2, 2024 08:45
@vdovhanych vdovhanych requested review from matejcik and mmilata August 2, 2024 09:14
@matejcik matejcik merged commit bb92a6b into main Aug 6, 2024
84 of 86 checks passed
@matejcik matejcik deleted the gh-actions-arm-emulator-builds branch August 6, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants