Skip to content

Regulatory screen for Eckhart #5582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

Regulatory screen for Eckhart #5582

merged 1 commit into from
Aug 19, 2025

Conversation

bieleluk
Copy link
Contributor

@bieleluk bieleluk commented Aug 19, 2025

Figma

  • The regulatory text is not translated (it shouldn't be IMO).
  • The Korean text contains unknown characters so it is in one big icon. There is also an icon with the logo only if the situation changes in the future.

TODO

  • label commit with [no changelog]

@bieleluk bieleluk self-assigned this Aug 19, 2025
@trezor-bot trezor-bot bot added this to Firmware Aug 19, 2025
@bieleluk bieleluk requested review from Copilot and removed request for matejcik and obrusvit August 19, 2025 10:37
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Aug 19, 2025
@bieleluk bieleluk requested review from ibz and romanz August 19, 2025 10:37
@bieleluk bieleluk added the T3W1 label Aug 19, 2025
@bieleluk bieleluk added this to the UI Eckhart milestone Aug 19, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a regulatory certification screen for the Eckhart device, providing users with regulatory information for different geographical zones including United States, Canada, Europe/UK, Australia/New Zealand, Ukraine, and South Korea.

  • Adds a new regulatory screen component with pagination support
  • Integrates the regulatory screen into the device menu as a new menu item
  • Includes translation support and icon resources for different regulatory zones

Reviewed Changes

Copilot reviewed 9 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
core/translations/signatures.json Updates translation file signatures
core/translations/order.json Adds ordering for new regulatory certification title
core/translations/en.json Adds English translation for regulatory certification title
core/mocks/trezortranslate_keys.pyi Adds type definition for new translation key
core/embed/rust/src/ui/layout_eckhart/theme/mod.rs Includes new regulatory certification icons
core/embed/rust/src/ui/layout_eckhart/firmware/regulatory_screen.rs Implements the main regulatory screen component
core/embed/rust/src/ui/layout_eckhart/firmware/mod.rs Exports regulatory screen components
core/embed/rust/src/ui/layout_eckhart/firmware/device_menu_screen.rs Integrates regulatory screen into device menu
core/embed/rust/librust_qstr.h Adds QSTR for new translation key

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

github-actions bot commented Aug 19, 2025

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 17079234467

Copy link
Contributor

@romanz romanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bieleluk bieleluk force-pushed the bieleluk/eckhart-regulatory branch 2 times, most recently from df554a7 to f23d8fb Compare August 19, 2025 18:41
@bieleluk bieleluk force-pushed the bieleluk/eckhart-regulatory branch from 79eacc1 to f251092 Compare August 19, 2025 19:03
@bieleluk bieleluk merged commit 0e72c21 into main Aug 19, 2025
103 checks passed
@bieleluk bieleluk deleted the bieleluk/eckhart-regulatory branch August 19, 2025 20:57
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants