-
-
Notifications
You must be signed in to change notification settings - Fork 710
Regulatory screen for Eckhart #5582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a regulatory certification screen for the Eckhart device, providing users with regulatory information for different geographical zones including United States, Canada, Europe/UK, Australia/New Zealand, Ukraine, and South Korea.
- Adds a new regulatory screen component with pagination support
- Integrates the regulatory screen into the device menu as a new menu item
- Includes translation support and icon resources for different regulatory zones
Reviewed Changes
Copilot reviewed 9 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
core/translations/signatures.json | Updates translation file signatures |
core/translations/order.json | Adds ordering for new regulatory certification title |
core/translations/en.json | Adds English translation for regulatory certification title |
core/mocks/trezortranslate_keys.pyi | Adds type definition for new translation key |
core/embed/rust/src/ui/layout_eckhart/theme/mod.rs | Includes new regulatory certification icons |
core/embed/rust/src/ui/layout_eckhart/firmware/regulatory_screen.rs | Implements the main regulatory screen component |
core/embed/rust/src/ui/layout_eckhart/firmware/mod.rs | Exports regulatory screen components |
core/embed/rust/src/ui/layout_eckhart/firmware/device_menu_screen.rs | Integrates regulatory screen into device menu |
core/embed/rust/librust_qstr.h | Adds QSTR for new translation key |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/embed/rust/src/ui/layout_eckhart/firmware/regulatory_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/regulatory_screen.rs
Outdated
Show resolved
Hide resolved
|
model | device_test | click_test | persistence_test |
---|---|---|---|
T2T1 | |||
T3B1 | |||
T3T1 | |||
T3W1 |
Latest CI run: 17079234467
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
core/embed/rust/src/ui/layout_eckhart/firmware/regulatory_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/regulatory_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/regulatory_screen.rs
Outdated
Show resolved
Hide resolved
df554a7
to
f23d8fb
Compare
[no changelog]
79eacc1
to
f251092
Compare
Figma
TODO
[no changelog]