-
-
Notifications
You must be signed in to change notification settings - Fork 710
chore(core/eckhart): invert QR screen colors #5589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR inverts the color scheme for QR code screens in the Eckhart layout to align with new design specifications from Figma. The changes implement a white background with black text/icons instead of the previous dark theme.
- Simplified QR screen component structure by removing action bar and header dependencies
- Added inverted color theme styles for buttons and text
- Updated QR screen layout to use a white background with black text elements
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
core/embed/rust/src/ui/layout_eckhart/theme/mod.rs | Adds new TEXT_SMALL_BLACK style for black text on white background |
core/embed/rust/src/ui/layout_eckhart/theme/firmware.rs | Introduces button_header_inverted() style with inverted colors |
core/embed/rust/src/ui/layout_eckhart/flow/receive.rs | Updates QR screen instantiation to use simplified constructor |
core/embed/rust/src/ui/layout_eckhart/firmware/qr_screen.rs | Complete refactor to use white background, simplified layout without action bar |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
5756093
to
4265458
Compare
[no changelog]
104b2aa
to
6be8009
Compare
This PR inverts the colors of Eckhart's
QRScreen
according to Figma.TODO
[no changelog]
to the commit message