Skip to content

chore(core/eckhart): invert QR screen colors #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2025

Conversation

bieleluk
Copy link
Contributor

@bieleluk bieleluk commented Aug 19, 2025

This PR inverts the colors of Eckhart's QRScreen according to Figma.

TODO

  • Figure out the color of the pressed button: asked in Figma thread
  • Add [no changelog] to the commit message

@bieleluk bieleluk requested a review from obrusvit as a code owner August 19, 2025 20:56
@trezor-bot trezor-bot bot added this to Firmware Aug 19, 2025
@bieleluk bieleluk marked this pull request as draft August 19, 2025 20:56
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Aug 19, 2025
@bieleluk bieleluk requested a review from Copilot August 19, 2025 20:56
@bieleluk bieleluk self-assigned this Aug 19, 2025
@bieleluk bieleluk added the T3W1 label Aug 19, 2025
@bieleluk bieleluk added this to the UI Eckhart milestone Aug 19, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR inverts the color scheme for QR code screens in the Eckhart layout to align with new design specifications from Figma. The changes implement a white background with black text/icons instead of the previous dark theme.

  • Simplified QR screen component structure by removing action bar and header dependencies
  • Added inverted color theme styles for buttons and text
  • Updated QR screen layout to use a white background with black text elements

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
core/embed/rust/src/ui/layout_eckhart/theme/mod.rs Adds new TEXT_SMALL_BLACK style for black text on white background
core/embed/rust/src/ui/layout_eckhart/theme/firmware.rs Introduces button_header_inverted() style with inverted colors
core/embed/rust/src/ui/layout_eckhart/flow/receive.rs Updates QR screen instantiation to use simplified constructor
core/embed/rust/src/ui/layout_eckhart/firmware/qr_screen.rs Complete refactor to use white background, simplified layout without action bar

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

github-actions bot commented Aug 19, 2025

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 17149896751

@bieleluk bieleluk added the translations Put this label on a PR to run tests in all languages label Aug 19, 2025
@bieleluk bieleluk force-pushed the bieleluk/eckhart-invert-qr branch from 5756093 to 4265458 Compare August 20, 2025 06:52
@bieleluk bieleluk marked this pull request as ready for review August 20, 2025 08:36
@bieleluk bieleluk requested a review from ibz August 20, 2025 08:36
@bieleluk bieleluk force-pushed the bieleluk/eckhart-invert-qr branch from 104b2aa to 6be8009 Compare August 22, 2025 08:10
@bieleluk bieleluk merged commit 031247b into main Aug 23, 2025
297 of 298 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Aug 23, 2025
@bieleluk bieleluk deleted the bieleluk/eckhart-invert-qr branch August 23, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T3W1 translations Put this label on a PR to run tests in all languages
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants