Skip to content

Address several DQA cases for Eckhart #5590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 23, 2025
Merged

Address several DQA cases for Eckhart #5590

merged 3 commits into from
Aug 23, 2025

Conversation

bieleluk
Copy link
Contributor

@bieleluk bieleluk commented Aug 19, 2025 •
edited
Loading

  • enable menu separators by default: report
  • enlarge right header button: report
  • enlarge left header button according to Figma
  • Change label flow:
    • A separate function for each flow due to the difference in Eckhart implementation.
    • Changed a confirm button label from Change to Confirm
    • Added a success screen

TODO

  • find out whether the header buttons should have a radius or not.
  • squash commits

@bieleluk bieleluk added this to the UI Eckhart milestone Aug 19, 2025
@bieleluk bieleluk self-assigned this Aug 19, 2025
@bieleluk bieleluk added the T3W1 label Aug 19, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Aug 19, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 17175458795

@bieleluk bieleluk added the translations Put this label on a PR to run tests in all languages label Aug 19, 2025
@bieleluk bieleluk force-pushed the bieleluk/eckhart-menu-separators branch from e172f9e to 0e70a47 Compare August 20, 2025 07:40
@bieleluk bieleluk changed the title chore(core/eckhart): enable menu separators by default WIP: address several DQA cases for Eckhart Aug 20, 2025
@bieleluk bieleluk marked this pull request as ready for review August 20, 2025 20:19
@bieleluk bieleluk changed the title WIP: address several DQA cases for Eckhart Address several DQA cases for Eckhart Aug 20, 2025
@bieleluk bieleluk force-pushed the bieleluk/eckhart-menu-separators branch from 8542d2c to 31f752f Compare August 21, 2025 16:41
obrusvit
obrusvit reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

@bieleluk
chore(core/eckhart): enable menu separators by default
34c1db9 
[no changelog]
@bieleluk
chore(core/eckhart): update apply settings label flow
5cf27b5 
- change button label and gradient
- add success screen after changing device name
[no changelog]
@bieleluk bieleluk force-pushed the bieleluk/eckhart-menu-separators branch from 8cb30cb to e74bf70 Compare August 23, 2025 11:47
@bieleluk
chore(core/eckhart): extend header buttons
05749db 
- use header builder functions where possible
- update fixtures
[no changelog]
@bieleluk bieleluk force-pushed the bieleluk/eckhart-menu-separators branch from e74bf70 to 05749db Compare August 23, 2025 12:29
@bieleluk bieleluk merged commit d8cff7a into main Aug 23, 2025
297 of 298 checks passed
@bieleluk bieleluk deleted the bieleluk/eckhart-menu-separators branch August 23, 2025 13:43
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibz ibz ibz approved these changes

@obrusvit obrusvit obrusvit approved these changes

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

Assignees

@bieleluk bieleluk

Labels
T3W1 translations Put this label on a PR to run tests in all languages
Projects
Firmware
Status: 🤝 Needs QA
Milestone
UI Eckhart
Development

Successfully merging this pull request may close these issues.
3 participants
@bieleluk @ibz @obrusvit