Skip to content

Duplicate of #3509 #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Duplicate of #3509 #5600

wants to merge 14 commits into from

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Aug 21, 2025

The only reason to open this is so I can see the UI diff of #3509 which comes from an external repo and cannot save UI diffs

@ibz ibz force-pushed the ibz/cardano-message-signing branch from 97619a8 to cc9176c Compare August 21, 2025 04:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 17147799525

@ibz ibz force-pushed the ibz/cardano-message-signing branch from cc9176c to 8b7e29f Compare August 21, 2025 09:38
@ibz ibz self-assigned this Aug 21, 2025
@ibz ibz added the translations Put this label on a PR to run tests in all languages label Aug 21, 2025
@ibz ibz force-pushed the ibz/cardano-message-signing branch from 13b279a to ccd6887 Compare August 21, 2025 14:48
jaskp and others added 12 commits August 21, 2025 17:08
@jaskp @ibz
feat(cardano): Message signing
a4fa3eb
@jaskp @ibz
feat(cardano): Show path, address params and longer payload chunk
597a867 
Show signing path, validate with keychain, show address parameters and increase max displayed bytes of first payload chunk unless signing hash.

Also add issue number to changelog.
@jaskp @ibz
fix(cardano): Change display_ascii flag to prefer_hex_display
015f7ee 
This makes the behavior more consistent with Ethereum message signing.
@jaskp @ibz
fix(cardano): Return pubkey
5a2f842 
This ends up being useful for software wallets.
@davidmisiak @ibz
chore(cardano): add missing translations
924c605
@davidmisiak @ibz
chore(cardano): update UI fixtures
646ffa2
@jaskp @ibz
chore(cardano): changes after rebase
83207dd
@jaskp @ibz
feat(cardano): stop hashing in message signing
a29d2c6
@jaskp @ibz
feat(cardano): replace chunking with length+offset
1601790
@jaskp @ibz
feat(cardano): reject probable hashes
c0f4b96
@jaskp @ibz
fix: changelog formatting
1248a5f
@ibz
chore(cardano): rename payload
9334b6c 
[no changelog]
@ibz ibz force-pushed the ibz/cardano-message-signing branch 2 times, most recently from f0eb138 to 7a07c36 Compare August 21, 2025 15:21
@ibz ibz force-pushed the ibz/cardano-message-signing branch from 7a07c36 to 6fb97f0 Compare August 21, 2025 17:24
@ibz ibz force-pushed the ibz/cardano-message-signing branch from 6fb97f0 to e648fd5 Compare August 22, 2025 06:22
@ibz ibz closed this Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit Awaiting requested review from obrusvit obrusvit will be requested when the pull request is marked ready for review obrusvit is a code owner

@matejcik matejcik Awaiting requested review from matejcik matejcik will be requested when the pull request is marked ready for review matejcik is a code owner

@romanz romanz Awaiting requested review from romanz romanz will be requested when the pull request is marked ready for review romanz is a code owner

@TychoVrahe TychoVrahe Awaiting requested review from TychoVrahe TychoVrahe will be requested when the pull request is marked ready for review TychoVrahe is a code owner

Assignees

@ibz ibz

Labels
translations Put this label on a PR to run tests in all languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibz @jaskp @davidmisiak