Adjust backlight normal settings to 85 #5605
Open
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[no changelog]
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3B1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3W1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
Latest CI run: 17191562429
TychoVrahe
requested changes
Aug 21, 2025
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| #include "rust_ui_bootloader.h" | |||
|
|
|||
| #define BACKLIGHT_NORMAL 150 | |||
There was a problem hiding this comment.
This (and the prodtest values) affect other models too, but i believe that this should only be done for T3W1 (or ratheer eckhart UI), so please add an ifdef. The prodtest values should probably be extracted to some single place.
There was a problem hiding this comment.
Fixup here ab6878a. It will do for now, but we should probably deal with this more elegantly in the future. How about to set the default values for every model in its model_.h file? That may be a good single reference for both bootloader & prodtest.
github-project-automation
bot
moved this from 🔎 Needs review
to 🏃♀️ In progress
in Firmware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of default normal backlight settings from 150->85 according to request from design