Suspend from application layer #5606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obrusvit
added
core
8 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR implements a simplified suspend functionality for the Trezor device application firmware. The implementation allows the device to enter a low-power state and wake up on button, BLE, or power events.
- Adds power button handling that either locks the device (when PIN is set) or suspends it (when no PIN is set)
- Implements suspend device functionality with configurable wakeup flags
- Integrates power button event detection into the UI event handling system
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
core/src/trezor/ui/__init__.py |
Adds power button event handling and integrates suspend functionality into the UI event loop |
core/src/apps/management/pm/suspend.py |
New module implementing the suspend device functionality with wakeup flag handling |
core/embed/upymod/qstrdefsport.h |
Adds string constants for the new suspend module to MicroPython's string table |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3B1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3W1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
Latest CI run: 17131271804
- power button event is handled before the event is passed to rust layout [no changelog]
obrusvit
force-pushed
the
obrusvit/firmware-suspend-simple
branch
from
3ca5d8b to
c7efbf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the first simplified version of suspend to the application firmware. More improvements will follow.
Description:
suspendintroduced to uPy in Firmware autodim #5417BTNstops all workflows and locks the device. Repeated powerBTNpress suspends the device.BTN/BLE/PWR- all treated equally - wakes up the deviceMissing:
PWRbutton (when charging starts)Supersedes #5199