Skip to content

fix(core): increase MAX_SUBSCREENS a bit #5610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Aug 21, 2025

Otherwise, entering the menu when connected via BLE results in a RSOD.

[23:04:01.509] === FATAL ERROR
[23:04:01.509] Location: src/ui/layout_eckhart/firmware/device_menu_screen.rs:373
[23:04:01.509] Message: unwrap failed

Reproduced on 375d6e1.

Otherwise, entering the menu when there is
a connected BLE device results in a RSOD.

[no changelog]
@romanz romanz self-assigned this Aug 21, 2025
@trezor-bot trezor-bot bot added this to Firmware Aug 21, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Aug 21, 2025
Copy link

github-actions bot commented Aug 21, 2025

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 17137608345

@romanz romanz marked this pull request as ready for review August 21, 2025 18:31
@romanz romanz requested a review from obrusvit as a code owner August 21, 2025 18:31
@romanz romanz requested a review from bieleluk August 21, 2025 18:31
@romanz romanz added the T3W1 label Aug 21, 2025
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@obrusvit obrusvit merged commit d86a50d into main Aug 22, 2025
229 of 241 checks passed
@obrusvit obrusvit deleted the romanz/fix-ble-menu branch August 22, 2025 08:36
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants