fix(python): correct CLI error message on uninitialized device #5613
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3B1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3W1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
Latest CI run: 17149560160
ibz
approved these changes
Aug 22, 2025
|
we already have please call the exception |
matejcik
reviewed
Aug 22, 2025
| @@ -307,6 +307,9 @@ def session_context( | |||
| sys.exit(1) | |||
| except exceptions.FailedSessionResumption: | |||
| sys.exit(1) | |||
| except exceptions.DerivationOnUninitaizedDeviceError: | |||
| click.echo("Device is not initialized.") | |||
| sys.exit(1) | |||
| except Exception: | |||
| click.echo("Failed to find a Trezor device.") | |||
There was a problem hiding this comment.
we definitely want to emit the exception in the log
maybe it's also a good idea to say f"(error was: {e})" or something?
romanz
added a commit
that referenced
this pull request
Aug 24, 2025
Following #5613. [no changelog]
romanz
added a commit
that referenced
this pull request
Aug 24, 2025
Following #5613. [no changelog]
romanz
added a commit
that referenced
this pull request
Aug 24, 2025
Following #5613. [no changelog]
romanz
added a commit
that referenced
this pull request
Aug 24, 2025
Following #5613. [no changelog]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[no changelog]