Support T3B1 in Suite #13544
Merged
Support T3B1 in Suite #13544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
komret
force-pushed
the
chore/add-t3b1-to-suite
branch
3 times, most recently
from
5b759a0 to
99e7d76
Compare
tomasklim
previously requested changes
Aug 5, 2024
tomasklim
reviewed
Aug 5, 2024
| @@ -1,6 +1,6 @@ | |||
| import { DeviceModelInternal } from '@trezor/connect'; | |||
|
|
|||
| const t2b1 = [ | |||
| const safe3 = [ | |||
There was a problem hiding this comment.
I dont like t2b1 nor safe3. Please come up with better naming
There was a problem hiding this comment.
homescreensT3B1 but definitely not just safe3,
tomasklim
reviewed
Aug 5, 2024
| @@ -814,6 +814,63 @@ | |||
| } | |||
| } | |||
| } | |||
| }, | |||
| { | |||
| "conditions": [ | |||
There was a problem hiding this comment.
I would do this in separate PR, it is kinda dangerous as we can forget to bump version/release config,...
There was a problem hiding this comment.
Since we are waiting for FW... let's wait and see.
Where exactly? |
komret
force-pushed
the
chore/add-t3b1-to-suite
branch
4 times, most recently
from
0e728fd to
d830312
Compare
komret
force-pushed
the
chore/add-t3b1-to-suite
branch
2 times, most recently
from
2cd4c10 to
2b9f556
Compare
Closed
komret
force-pushed
the
chore/add-t3b1-to-suite
branch
10 times, most recently
from
c25667e to
38fd6dc
Compare
komret
requested review from
tsusanka,
marekrjpolak,
a team and
matejkriz
as code owners
Lemonexe
reviewed
Sep 3, 2024
packages/suite/src/components/firmware/ReconnectDevicePrompt.tsx
Outdated
Show resolved
Hide resolved
Lemonexe
reviewed
Sep 3, 2024
|
I added one last fixup (8ea3bf0) bumping the version is message-system because we are going to release T3B1 next month. Going to merge it now. |
|
/rebase |
trezor-ci
force-pushed
the
chore/add-t3b1-to-suite
branch
from
8ea3bf0 to
1a66d9b
Compare
komret
force-pushed
the
chore/add-t3b1-to-suite
branch
from
840896b to
a8b2c94
Compare
komret
force-pushed
the
chore/add-t3b1-to-suite
branch
from
a8b2c94 to
39e233b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isDeviceWithButtonsutil).yarn update-coinsso that it is synchronized with trezor-common, no manual changes there.TODO:
releases.json- waiting for FW.How I created the single-frame hologram video for
DeviceAnimationcomponent:ffmpeg -loop 1 -i input.webp -c:v libvpx-vp9 -t 5 -pix_fmt yuv420p output.webmffmpeg -c:v libvpx-vp9 -i t1_success_dark.webm -vf scale=720:-1 t1_success_dark.webm(chore(suite-data): compress videos #6358)