Fix/thp sync after send #20951
Merged
Fix/thp sync after send #20951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonlesisz
requested review from
mroz22,
martykan and
marekrjpolak
as code owners
szymonlesisz
added
the
no-project
mroz22
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ThpState was unsynchronized after Cancelling ButtonRequest, its because of missing line (probably during rebases)
thpState?.sync('send', name);inAbstractApiTransportfor the reference the same line is present inBridgeTransport. while doint the tests i also noticed thatabortThpWorkflowdidnt reject/abort pendingdevice.currentRunpromise and hungs forever.remove error from
decodeSendAck- function which reads ThpAck after send, related to Ignore re-transmitted THP payloads on host trezor-firmware#5578 (comment) (FW will also ignore unexpected messages)complex tests of ThpState lifecycle when Cancel is called
🔍🖥️ Suite desktop test results: View in Currents
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite native android test results: View in Currents