Skip to content

Use julia-downgrade-compat@v2 #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Use julia-downgrade-compat@v2 #2507

wants to merge 7 commits into from

Conversation

JoshuaLampert
Copy link
Member

With the new julia-downgrade-compat v2, the action switched to use Resolver.jl to find minimal compatible versions. If everything works as intended, this makes it MUCH simpler to work with and debug the downgrade action because in case of incompatible lower bounds, you don't need to resolve the incompatibilities manually by finding out a set of working minimal bounds. This should now be done by Resolver.jl.

Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@JoshuaLampert JoshuaLampert marked this pull request as draft July 29, 2025 22:43
@JoshuaLampert
Copy link
Member Author

We also run into StefanKarpinski/Resolver.jl#15. DiffEqBase.jl v6.155.2 and v6.155.3 are yanked, but Resolver.jl doesn't realize that and wants to take v6.155.2.

@JoshuaLampert
Copy link
Member Author

And we still get some of the Unsatisfiable requirements detected errors. I thought Resolver.jl would be smart enough to get around these. I thought that's actually the whole point, but either I'm misunderstanding something or there are still bugs in Resolver.jl... 😬

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (035aec0) to head (07a59b2).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2507   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files         511      512    +1     
  Lines       42278    42300   +22     
=======================================
+ Hits        40875    40897   +22     
  Misses       1403     1403           
Flag Coverage Δ
unittests 96.68% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant