-
Notifications
You must be signed in to change notification settings - Fork 126
Use julia-downgrade-compat@v2 #2507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
We also run into StefanKarpinski/Resolver.jl#15. DiffEqBase.jl v6.155.2 and v6.155.3 are yanked, but Resolver.jl doesn't realize that and wants to take v6.155.2. |
And we still get some of the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2507 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 511 512 +1
Lines 42278 42300 +22
=======================================
+ Hits 40875 40897 +22
Misses 1403 1403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
With the new julia-downgrade-compat v2, the action switched to use Resolver.jl to find minimal compatible versions. If everything works as intended, this makes it MUCH simpler to work with and debug the downgrade action because in case of incompatible lower bounds, you don't need to resolve the incompatibilities manually by finding out a set of working minimal bounds. This should now be done by Resolver.jl.