-
Notifications
You must be signed in to change notification settings - Fork 126
return nothing
& helper functions for custom time integrators
#2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
return nothing
& helper functions for custom time integrators
#2517
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
return nothing
for the curstom time integratorsreturn nothing
for the custom time integrators
return nothing
for the custom time integratorsreturn nothing
for the custom time integrators, unify callback functions
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2517 +/- ##
=======================================
Coverage ? 96.75%
=======================================
Files ? 512
Lines ? 42387
Branches ? 0
=======================================
Hits ? 41010
Misses ? 1377
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
return nothing
for the custom time integrators, unify callback functionsreturn nothing
& helper functions for custom time integrators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
Follows upon #2516 .
Also, I am bundling some helper functions to avoid duplicated code.