-
Notifications
You must be signed in to change notification settings - Fork 95
fix(release)!: Fix react-uswds release pipeline #3148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@NamibiaTorres @brandonlenz I see one failing test, and despite the name of the test, it seems to be failing on modal open. Happy to approve once the test passes. |
Wild. I can't think of anything on this PR that would cause that. I'm re-running just in case its a flaky test (not that I'll be super happy if it passes, but it would at least warrant not going down a crazy rabbit hole just yet) |
Working on this now. It seems the structure of the response has changed, and I'm looking to see what it currently is: https://github.com/orgs/community/discussions/153882#discussioncomment-12491480 |
Found a snapshot here of what the response is supposed to look like: https://github.com/npm/npm-audit-report/blob/dceb293fdda756fb532a4a5a0ba62b7853d849e1/tap-snapshots/test-reporters-json.js-TAP.test.js#L1244-L1285 Coding around that. |
|
Summary
Doing some changes to try to fix our release and CI with @NamibiaTorres
Related Issues or PRs
#3095
How To Test
Will likely need: