Skip to content

Conversation

brandonlenz
Copy link
Contributor

@brandonlenz brandonlenz commented May 13, 2025

Summary

Doing some changes to try to fix our release and CI with @NamibiaTorres

Related Issues or PRs

#3095

  • TODO: Try to get release please to do 9.2.0 again (but as a breaking release, so it will be 10.0.0)
    • Delete 9.2.0 tag from github
    • Manually remove 9.2.0 from Changelog.md
    • revert release please manifest
    • This should be considered breaking due to the title of this PR ("!")
    • This should instead create 10.0.0 as a result
  • Fix "Couldn't find summary of vulnerabilities from yarn audit" (fix(release)!: Fix react-uswds release pipeline #3148 (comment))
  • Fix "Lint" check, which is currently "waiting"

How To Test

Will likely need:

  1. to be merged
  2. let release-please create a PR
  3. merge the release-please PR
  4. Verify tag creation is as expected

Copy link
Contributor

github-actions bot commented May 13, 2025

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against b4254f9

@brandonlenz brandonlenz changed the title chore: Fix latest release fix(release)!: Fix latest release May 13, 2025
@brandonlenz brandonlenz changed the title fix(release)!: Fix latest release fix(release)!: Fix react-uswds release pipeline May 13, 2025
@brandonlenz brandonlenz marked this pull request as ready for review May 13, 2025 17:21
@brandonlenz brandonlenz requested a review from a team as a code owner May 13, 2025 17:21
@rswerve
Copy link
Contributor

rswerve commented May 13, 2025

@NamibiaTorres @brandonlenz I see one failing test, and despite the name of the test, it seems to be failing on modal open. Happy to approve once the test passes.

@brandonlenz
Copy link
Contributor Author

brandonlenz commented May 13, 2025

@NamibiaTorres @brandonlenz I see one failing test, and despite the name of the test, it seems to be failing on modal open. Happy to approve once the test passes.

Wild. I can't think of anything on this PR that would cause that. I'm re-running just in case its a flaky test (not that I'll be super happy if it passes, but it would at least warrant not going down a crazy rabbit hole just yet)

rswerve
rswerve previously approved these changes May 13, 2025
@brandonlenz
Copy link
Contributor Author

Warnings
⚠️ Couldn't find summary of vulnerabilities from yarn audit

Generated by 🚫 dangerJS against 01562aa

Working on this now. It seems the structure of the response has changed, and I'm looking to see what it currently is:

https://github.com/orgs/community/discussions/153882#discussioncomment-12491480

@brandonlenz
Copy link
Contributor Author

Warnings
⚠️ Couldn't find summary of vulnerabilities from yarn audit
Generated by 🚫 dangerJS against 01562aa

Working on this now. It seems the structure of the response has changed, and I'm looking to see what it currently is:

https://github.com/orgs/community/discussions/153882#discussioncomment-12491480

Found a snapshot here of what the response is supposed to look like: https://github.com/npm/npm-audit-report/blob/dceb293fdda756fb532a4a5a0ba62b7853d849e1/tap-snapshots/test-reporters-json.js-TAP.test.js#L1244-L1285

Coding around that.

@brandonlenz
Copy link
Contributor Author

Warnings
⚠️ Couldn't find summary of vulnerabilities from yarn audit
Generated by 🚫 dangerJS against 01562aa

Working on this now. It seems the structure of the response has changed, and I'm looking to see what it currently is:
https://github.com/orgs/community/discussions/153882#discussioncomment-12491480

Found a snapshot here of what the response is supposed to look like: https://github.com/npm/npm-audit-report/blob/dceb293fdda756fb532a4a5a0ba62b7853d849e1/tap-snapshots/test-reporters-json.js-TAP.test.js#L1244-L1285

Coding around that.

Fixed:
image

@brandonlenz brandonlenz enabled auto-merge (squash) May 14, 2025 21:58
@brandonlenz brandonlenz merged commit 70456f2 into main May 15, 2025
7 checks passed
@brandonlenz brandonlenz deleted the fix-release-9.2.0 branch May 15, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants