fix: update FilePreview to handle multiple renders in strict mode #3236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A bug exists in the FilePreview component that prevents the FileInput component from correctly rendering when a file is uploaded in React Strict Mode. Because Strict Mode requires components to render twice, the mount logic in FilePreview will run twice, causing an error to be throw in relation to the FileReader object being accessed multiple times:
Note that this fix comes directly from the comment from @TomNUSDS (hi Tom!) here #2433 (comment)
Related Issues or PRs
Closes #2433
How To Test
Reproduce bug
framework
config should look likenpm run storybook
Verify fix
Screenshots (optional)