Skip to content

Add set_metadata parameter #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Add set_metadata parameter #449

merged 2 commits into from
Jan 16, 2025

Conversation

hyanwong
Copy link
Member

Fixes #302. As described in that issue, we issue a warning and don't write metadata for old tsinfer versions (these have no schema, and raw byte metadata in the nodes table)

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense, couple of comments. I assume the other tests test the None default case?

@hyanwong hyanwong merged commit 240593d into tskit-dev:main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"set_metadata" parameter
2 participants