Skip to content

Conversation

NthPortal
Copy link
Contributor

Rename mapK methods that take a KindTransformer to liftTo.

This change is preparation for #1001

@NthPortal NthPortal requested a review from iRevive June 26, 2025 17:32
@NthPortal NthPortal added the module:core Features and improvements to core module label Jun 26, 2025
@mergify mergify bot added the tracing Improvements to tracing module label Jun 26, 2025
@NthPortal
Copy link
Contributor Author

NthPortal commented Jun 26, 2025

@iRevive mimaReportBinaryIssues seems to be doing nothing because no previous artifact is set. I see some exclusions in build.sbt though, so it seems like it must have been working at some point (either that or someone wrote them by hand). any idea what happened?

@NthPortal
Copy link
Contributor Author

NthPortal commented Jun 26, 2025

mimaReportBinaryIssues seems to be doing nothing because no previous artifact is set

... it seems to work fine on CI 🙃. it'd be nice if it worked locally too, but at least I have the list of exclusions now

Copy link
Contributor

@iRevive iRevive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. One question about the versioning.

@NthPortal
Copy link
Contributor Author

we should probably wait until a decision gets made in cats-mtl before merging this

@NthPortal
Copy link
Contributor Author

typelevel/cats-mtl#639 got merged, so I think calling it liftTo is good to go

Rename `mapK` methods that take a `KindTransformer` to `liftTo`.
@mergify mergify bot added the logs Improvements to logs module label Aug 19, 2025
@NthPortal
Copy link
Contributor Author

some methods don't get deprecations because they haven't been in a released version yet

@armanbilge
Copy link
Member

it'd be nice if it worked locally too

@NthPortal does your local repo have all the tags?

@NthPortal
Copy link
Contributor Author

does your local repo have all the tags?

apparently I had not fetched in a while, and it did not

@NthPortal
Copy link
Contributor Author

this got a spurious/transient test failure, which is slightly concerning, but I guess we'll deal with it if it becomes frequent

@NthPortal NthPortal merged commit b878abd into typelevel:main Aug 19, 2025
19 of 21 checks passed
@NthPortal NthPortal deleted the liftTo/PR branch August 19, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logs Improvements to logs module module:core Features and improvements to core module tracing Improvements to tracing module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants