-
Notifications
You must be signed in to change notification settings - Fork 43
Rename most mapK
methods to liftTo
#1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
... it seems to work fine on CI 🙃. it'd be nice if it worked locally too, but at least I have the list of exclusions now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. One question about the versioning.
core/common/src/main/scala/org/typelevel/otel4s/meta/InstrumentMeta.scala
Show resolved
Hide resolved
we should probably wait until a decision gets made in cats-mtl before merging this |
typelevel/cats-mtl#639 got merged, so I think calling it |
Rename `mapK` methods that take a `KindTransformer` to `liftTo`.
some methods don't get deprecations because they haven't been in a released version yet |
@NthPortal does your local repo have all the tags? |
apparently I had not fetched in a while, and it did not |
this got a spurious/transient test failure, which is slightly concerning, but I guess we'll deal with it if it becomes frequent |
Rename
mapK
methods that take aKindTransformer
toliftTo
.This change is preparation for #1001