Skip to content

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Jul 30, 2025

Fixes #1027.

@iRevive iRevive requested a review from NthPortal July 30, 2025 13:17
@mergify mergify bot added module:oteljava Features and improvements to the oteljava module tracing Improvements to tracing module labels Jul 30, 2025
@iRevive
Copy link
Contributor Author

iRevive commented Jul 30, 2025

Should it be enough to expose the resetSpans method? WDYT @fmonniot?

@iRevive iRevive added the documentation Improvements or additions to documentation label Jul 30, 2025
@iRevive iRevive force-pushed the oteljava/testkit-reset-spans branch from 3326d21 to fd34d06 Compare July 30, 2025 13:30
@fmonniot
Copy link

That would work for me! Thanks for tackling that one so fast.

@iRevive iRevive added the breaking The changes are semantically or binary breaking label Aug 1, 2025
Copy link
Contributor

@NthPortal NthPortal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. sorry it took me so long to review

@iRevive iRevive merged commit de1d02d into typelevel:main Aug 15, 2025
11 checks passed
@iRevive iRevive deleted the oteljava/testkit-reset-spans branch August 15, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking The changes are semantically or binary breaking documentation Improvements or additions to documentation module:oteljava Features and improvements to the oteljava module tracing Improvements to tracing module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TracesTestkit#finishedSpans documentation wrongly state that spans are cleaned up
3 participants