Skip to content

fix line comments with control blocks #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025

Conversation

drecouse
Copy link
Contributor

Line comments used on control blocks like this made the content inside the control block disappear:

LineComment(For([...], {
  Assign([...])
}), [comment])

@quachpas quachpas self-requested a review July 28, 2025 19:30
@quachpas quachpas self-assigned this Jul 28, 2025
@quachpas
Copy link
Collaborator

Hi @drecouse, thanks for the patch. Would you be able to create a test for that specific behaviour code?

@drecouse
Copy link
Contributor Author

drecouse commented Jul 30, 2025

Sure, I have added a test with nested for and while blocks.

@quachpas
Copy link
Collaborator

quachpas commented Aug 6, 2025

That looks perfect! Thank you!

@quachpas quachpas merged commit 688ac33 into typst-community:main Aug 6, 2025
1 check passed
quachpas added a commit that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants