CTP-3558 coding std short array syntax

Author: watson8

actions/ajax/datatable/grading.php

@@ -35,7 +35,7 @@
 $unallocated = optional_param('unallocated', false, PARAM_BOOL);
 
 // Grading report display options.
-$report_options = array();
+$report_options = [];
 if ($unallocated) {
     $report_options['unallocated'] = true;
 }

actions/allocate.php

@@ -45,7 +45,7 @@
 $assessorallocationstrategy = optional_param('assessorallocationstrategy', false, PARAM_TEXT);
 
 $moderationruletype = optional_param('addmodsetruletype', 0, PARAM_ALPHAEXT);
-$deletemodsetrule = optional_param('delete-mod-set-rule', array(), PARAM_RAW) ;
+$deletemodsetrule = optional_param('delete-mod-set-rule', [], PARAM_RAW) ;
 
 // options used for pagination
 // If a session variable holding page preference for the specific coursework is not set, set default value (0).
@@ -76,7 +76,7 @@
 $options = compact('sortby', 'sorthow', 'perpage', 'page');
 
 // $_POST['allocatables'] comes as array of arrays which is not supported by optional_param_array, however we clean this later in process_data() function
-$formdataarray = isset($_POST['allocatables']) ? $_POST['allocatables'] : array();
+$formdataarray = isset($_POST['allocatables']) ? $_POST['allocatables'] : = [];
 
 require_login($course, true, $coursemodule);
 

actions/allocationsession.php

@@ -26,20 +26,20 @@
 
 $assesorselect = required_param_array('assesorselect', PARAM_RAW);
 $assesorselectvalue = required_param_array('assesorselectvalue', PARAM_RAW);
-$pinnedchk = optional_param_array('pinned', array(), PARAM_RAW);
-$pinnedchkval = optional_param_array('pinnedvalue', array(), PARAM_RAW);
-$moderatorselect = optional_param_array('moderatorselect', array(), PARAM_RAW);
-$moderatorselectvalue = optional_param_array('moderatorselectvalue', array(), PARAM_RAW);
-$samplechk = optional_param_array('sample', array(), PARAM_RAW);
-$samplechkvalue = optional_param_array('samplevalue', array(), PARAM_RAW);
+$pinnedchk = optional_param_array('pinned', [], PARAM_RAW);
+$pinnedchkval = optional_param_array('pinnedvalue', [], PARAM_RAW);
+$moderatorselect = optional_param_array('moderatorselect', [], PARAM_RAW);
+$moderatorselectvalue = optional_param_array('moderatorselectvalue', [], PARAM_RAW);
+$samplechk = optional_param_array('sample', [], PARAM_RAW);
+$samplechkvalue = optional_param_array('samplevalue', [], PARAM_RAW);
 $coursemoduleid = required_param('coursemoduleid', PARAM_INT);
 
 if (!isset($SESSION->coursework_allocationsessions)) {
-    $SESSION->coursework_allocationsessions = array();
+    $SESSION->coursework_allocationsessions = [];
 }
 
 if (!isset($SESSION->coursework_allocationsessions[$coursemoduleid])) {
-    $SESSION->coursework_allocationsessions[$coursemoduleid] = array();
+    $SESSION->coursework_allocationsessions[$coursemoduleid] = [];
 }
 
 for ($i = 0; $i < count($assesorselect); $i++) {

actions/set_personal_deadlines.php

@@ -62,7 +62,7 @@
         'node-base')
 );
 $PAGE->requires->js_init_call('M.mod_coursework.init_personal_deadlines_page',
-    array(),
+    [],
     false,
     $jsmodule);
 

backup/moodle2/restore_coursework_activity_task.class.php

@@ -33,7 +33,7 @@ class restore_coursework_activity_task extends restore_activity_task
      * @return array of restore_decode_rule
      */
     static public function define_decode_rules() {
-        $rules = array();
+        $rules = [];
 
         $rules[] = new restore_decode_rule('COURSEWORKBYID',
                                            '/mod/coursework/view.php?id=$1',
@@ -53,7 +53,7 @@ static public function define_decode_rules() {
      * @return array
      */
     static public function define_decode_contents() {
-        $contents = array();
+        $contents = [];
 
         $contents[] = new restore_decode_content('coursework', array('intro'), 'assign');
 

backup/moodle2/restore_coursework_stepslib.php

@@ -39,7 +39,7 @@ static function cheaplog($thing, $append = true) {
      * @return restore_path_element $structure
      */
     protected function define_structure() {
-        $paths = array();
+        $paths = [];
 
         $paths[] = new restore_path_element('coursework', '/activity/coursework');
         $paths[] = new restore_path_element('coursework_sample_set_rule', '/activity/coursework/coursework_sample_set_rules/coursework_sample_set_rule');

classes/allocation/manager.php

@@ -69,7 +69,7 @@ public function __construct(coursework $coursework) {
         $this->coursework = $coursework;
 
         // Instantiate the allocation strategies so we can use them.
-        $strategytypes = array();
+        $strategytypes = [];
         if (!empty($this->coursework->assessorallocationstrategy)) {
             $strategytypes[] = coursework::ASSESSOR;
         }
@@ -110,7 +110,7 @@ public static function get_allocation_classnames($type = coursework::ASSESSOR) {
 
         $classdir = $CFG->dirroot . '/mod/coursework/classes/allocation/strategy';
         $fullclassnames = glob($classdir . '/*.php');
-        $options = array();
+        $options = [];
         foreach ($fullclassnames as $fullclassname) {
             if (strpos($fullclassname, 'base') !== false) {
                 continue;
@@ -169,7 +169,7 @@ public function auto_generate_moderation_set() {
         }
 
         // These are the ones we will actually moderate (or which have already been moderated).
-        $moderation_set = array();
+        $moderation_set = [];
 
         // Move all the already marked ones into the set. These have to stay in it and ought to
         // be taken into account so that the other rules just add to them.
@@ -289,7 +289,7 @@ public function auto_generate_sample_set() {
         $sampleplugins = $DB->get_records('coursework_sample_set_plugin', null, 'pluginorder');
         $order = 0;
 
-        $sample_set = array();
+        $sample_set = [];
 
         $allocatables = $this->get_coursework()->get_allocatables();
 
@@ -331,7 +331,7 @@ public function auto_generate_sample_set() {
                     if (!isset($manual_sample_set[$k])) $manual_sample_set[$k] = $v;
                 }
 
-                $auto_sample_set = array();
+                $auto_sample_set = [];
 
                 foreach ($sampleplugins as $plugin) {
                     $classname = '\mod_coursework\sample_set_rule\\' . $plugin->rulename;

classes/allocation/strategy/base.php

@@ -64,7 +64,7 @@ abstract class base {
      *
      * @var array
      */
-    private $settings = array();
+    private $settings = [];
 
     /**
      * @var stage_base

classes/allocation/strategy/equal.php

@@ -86,7 +86,7 @@ public function save_allocation_strategy_options() {
      * @return mixed
      */
     protected function list_of_allocatable_teachers_and_their_current_number_of_allocations($teachers, $student) {
-        $teacherids = array();
+        $teacherids = [];
 
         foreach ($teachers as $id => $teacher) {
             if ($this->teacher_already_has_an_allocation_for_this_allocatable($student, $teacher)) {

classes/allocation/strategy/group_assessor.php

@@ -66,6 +66,6 @@ public function save_allocation_strategy_options() {
      * @return mixed
      */
     protected function list_of_allocatable_teachers_and_their_current_number_of_allocations($teachers, $student) {
-        return array();
+        return = [];
     }
 }