CTP-3716 deprecated constant #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspark21
approved these changes
Aug 19, 2024
aspark21
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
This still doesn't fix https://github.com/ucl-isd/moodle-mod_coursework/actions/runs/10451472146/job/28937958025#step:6:41
but I will merge
aspark21
deleted the
CTP-3716-Coursework-CI-tests-install-fails-after-MESSAGE_DEFAULT_LOGGEDIN-deprecated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this alone will resolve the CI install issue but worth fixing as it's one of the things causing an error. The others are more involved and I have them in another branch