Skip to content

[UNDERTOW-2552] fix: add non-ascii support for big formData value #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

halcsi19790320
Copy link

FileItem.getValue not works well with non-ascii characters

@shizhenhua01
Copy link

shizhenhua01 commented May 12, 2025 via email

@halcsi19790320 halcsi19790320 changed the title fix: add non-ascii support for big formData value [UNDERTOW-2552] fix: add non-ascii support for big formData value May 12, 2025
@baranowb baranowb requested review from ropalka, fl4via and baranowb May 19, 2025 07:58
@baranowb baranowb added bug fix Contains bug fix(es) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels May 19, 2025
@baranowb
Copy link
Contributor

@halcsi19790320 - could you please update commit message to following format: "[UNDERTOW-12345] description" ?

@baranowb
Copy link
Contributor

@halcsi19790320
Looks like there are checkstyle violations:
Error: /home/runner/work/undertow/undertow/core/src/main/java/io/undertow/util/FileUtils.java:78:9: Line contains a tab character. [FileTabCharacter]
Error: /home/runner/work/undertow/undertow/core/src/main/java/io/undertow/util/FileUtils.java:82:13: Line contains a tab character. [FileTabCharacter]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:267: Line has trailing spaces. [RegexpSingleline]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:343: Line has trailing spaces. [RegexpSingleline]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:356: Line has trailing spaces. [RegexpSingleline]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:371: Line has trailing spaces. [RegexpSingleline]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:373:5: Line contains a tab character. [FileTabCharacter]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:374:1: Line contains a tab character. [FileTabCharacter]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:375:1: Line contains a tab character. [FileTabCharacter]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:376:1: Line contains a tab character. [FileTabCharacter]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:377:1: Line contains a tab character. [FileTabCharacter]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:378:1: Line contains a tab character. [FileTabCharacter]
Error: /home/runner/work/undertow/undertow/core/src/test/java/io/undertow/server/handlers/form/MultipartFormDataParserTestCase.java:379: Line has trailing spaces. [RegexpSingleline]

Copy link
Contributor

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating Strings during stream parsing was wrong.

@baranowb baranowb added waiting PR update Awaiting PR update(s) from contributor before merging on hold PR awaits non CI/Review holdover and removed waiting peer review PRs that edit core classes might require an extra review labels May 19, 2025
@halcsi19790320
Copy link
Author

I updated this commit. I hope it is good now.

@halcsi19790320 halcsi19790320 requested a review from baranowb May 20, 2025 11:01
@baranowb baranowb removed the waiting PR update Awaiting PR update(s) from contributor before merging label Jun 16, 2025
@baranowb baranowb removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check on hold PR awaits non CI/Review holdover labels Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Contains bug fix(es)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants