Skip to content

[UNDERTOW-1870] Backport of RFE with property instead of API change #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.3.x
Choose a base branch
from
Open

[UNDERTOW-1870] Backport of RFE with property instead of API change #1731

wants to merge 1 commit into from

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb requested review from jasondlee, ropalka and fl4via June 30, 2025 09:16
@baranowb baranowb added under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) backport The PR is the result of backporting another PR to a maintainance branch waiting peer review PRs that edit core classes might require an extra review labels Jun 30, 2025
baranowb
baranowb commented Jul 7, 2025
View reviewed changes
servlet/src/main/java/io/undertow/servlet/spec/AsyncContextImpl.java
@@ -87,7 +87,7 @@ public class AsyncContextImpl implements AsyncContext {

//todo: make default configurable
private volatile long timeout = 30000;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be prefixed DEFAULT_ ?

@baranowb baranowb mentioned this pull request Jul 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondlee jasondlee Awaiting requested review from jasondlee

@ropalka ropalka Awaiting requested review from ropalka

@fl4via fl4via Awaiting requested review from fl4via

Assignees
No one assigned
Labels
backport The PR is the result of backporting another PR to a maintainance branch new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@baranowb