[UNDERTOW-2370] Guard against non-servlet ctx request with ServletNam… #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eAttribute in access log
baranowb
added
bug fix
msfm
suggested changes
Jul 15, 2025
| if (src != null) { | ||
| return src.getCurrentServlet().getManagedServlet().getServletInfo().getName(); | ||
| } else { | ||
| return UNDEFINED; |
There was a problem hiding this comment.
Could you explain the reasoning behind intentionally returning "No-Servlet" here?
I was thinking that returning null would be sufficient, as it gets logged as - in the access log by default. This would also align with other ExchangeAttributes, which typically return null when a value isn't available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eAttribute in access log
Issue: https://issues.redhat.com/browse/UNDERTOW-2370