Skip to content

feat(linux): Add ffmpeg #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025
Merged

feat(linux): Add ffmpeg #159

merged 2 commits into from
May 3, 2025

Conversation

unknowIfGuestInDream
Copy link
Owner

@unknowIfGuestInDream unknowIfGuestInDream commented May 3, 2025

CLose #153

Fixes #

Proposed Changes

  1. ...
  2. ...
  3. ...

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as either enhancement, bug, documentation or style
  • Verify design and implementation

Summary by Sourcery

Documentation:

  • Add ffmpeg installation guide to the Linux software installation sidebar

Summary by CodeRabbit

  • Documentation
    • Added a new sidebar entry for FFmpeg installation in the Linux section.
    • Introduced a detailed guide for installing FFmpeg on Tencent CentOS 8, including repository setup, installation steps, and verification instructions.

CLose #153

Signed-off-by: unknowIfGuestInDream <liang.tang.cx@gmail.com>
Copy link

sourcery-ai bot commented May 3, 2025

Reviewer's Guide

This pull request adds a link to the new ffmpeg installation guide in the Linux documentation sidebar.

File-Level Changes

Change Details Files
Added ffmpeg installation documentation link
  • Added an entry for '安装ffmpeg' linking to linux/soft/ffmpeg.md in the sidebar menu.
docs/linux/_sidebar.md

Assessment against linked issues

Issue Objective Addressed Explanation
#153 Add documentation for installing FFmpeg on Linux. The provided diff only modifies the sidebar, not adding any content about FFmpeg installation.
#153 Address the feature request to provide instructions or guidance on installing FFmpeg on Linux systems. The PR only modifies the sidebar, and does not include any actual installation instructions or documentation for FFmpeg.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

vercel bot commented May 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
document ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2025 1:33pm

Copy link

quine-bot bot commented May 3, 2025

👋 Figuring out if a PR is useful is hard, hopefully this will help.

  • @unknowIfGuestInDream has been on GitHub since 2019 and in that time has had 1226 public PRs merged
  • Don't you recognize them? They've been here before 🎉
  • Here's a good example of their work: javafxTool (Javafx scaffolding, built on JDK17 + JavaFX21 + controlsfx 11.x.x + Maven)
  • From looking at their profile, they seem to be good with Java and HTML.

Their most recently public accepted PR is: unknowIfGuestInDream/javafxTool#2128

Copy link

coderabbitai bot commented May 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A new documentation entry for installing FFmpeg on Tencent CentOS 8 has been added. The sidebar navigation was updated to include this new FFmpeg installation guide directly after the Oracle installation entry. The new documentation describes the steps to enable necessary repositories and install FFmpeg using the Negativo17 repository, followed by a verification step. No code or public API changes were made.

Changes

File(s) Change Summary
docs/linux/_sidebar.md Added "安装ffmpeg" entry to the sidebar after the "安装oracle" item.
docs/linux/soft/ffmpeg.md New documentation file providing step-by-step instructions for installing FFmpeg on CentOS 8.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Sidebar
    participant FFmpegDoc

    User->>Sidebar: Selects "安装ffmpeg"
    Sidebar->>FFmpegDoc: Opens FFmpeg installation guide
    FFmpegDoc->>User: Displays installation steps and verification
Loading

Assessment against linked issues

Objective Addressed Explanation
Provide documentation for installing FFmpeg on Linux (CentOS 8) (#153)

Poem

A sidebar hop, a doc appears,
FFmpeg install—no more fears!
CentOS steps, repositories align,
Negativo17 brings codecs fine.
A bunny’s joy, a guide so neat,
Now your videos can’t be beat! 🐇🎬


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f0c014 and d29ac54.

📒 Files selected for processing (2)
  • docs/linux/_sidebar.md (1 hunks)
  • docs/linux/soft/ffmpeg.md (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the linux label May 3, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @unknowIfGuestInDream - I've reviewed your changes - here's some feedback:

  • This PR's title mentions adding ffmpeg, but the code changes only involve adding a newline to a sidebar file.
  • Please fill out the 'Proposed Changes' section in the description to explain the changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

CLose #153

Signed-off-by: unknowIfGuestInDream <liang.tang.cx@gmail.com>
@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 3, 2025
@unknowIfGuestInDream unknowIfGuestInDream merged commit 0871605 into master May 3, 2025
16 of 18 checks passed
@unknowIfGuestInDream unknowIfGuestInDream deleted the pr-153 branch May 3, 2025 13:35
@quine-bot quine-bot bot mentioned this pull request May 3, 2025
3 tasks
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue or pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Linux安装FFmpeg
1 participant