fix: Fix stage hidden action In Mac Arm #2133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close #878 Signed-off-by: IfGuestInDream <ifGuestInDream@163.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for following naming conventions! 😻 |
Their most recently public accepted PR is: #2132 |
Walkthrough此次变更主要针对 macOS 系统，扩展了对截图和取色器窗口可见性设置的特殊处理。在首选项视图和系统设置控制器中，新增了对这两个相关设置的可见性和可用性控制。此外，针对截图窗口的关闭流程，引入了并发保护机制，防止多次关闭操作，并确保 UI 恢复操作在 JavaFX 主线程中异步执行。 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PreferencesView
participant SystemSettingController
participant ScreenshotStage
participant JavaFXThread
User->>PreferencesView: 初始化
PreferencesView->>PreferencesView: 检测 macOS
PreferencesView->>PreferencesView: 设置 supScreenshotHideWindow/supScreenColorPickerHideWindow 可见性为 false
User->>SystemSettingController: 初始化/操作
SystemSettingController->>SystemSettingController: 检测 macOS
SystemSettingController->>SystemSettingController: 禁用相关 CheckBox
User->>ScreenshotStage: 结束截图操作
ScreenshotStage->>ScreenshotStage: 检查 isClosing
alt isClosing=false
ScreenshotStage->>ScreenshotStage: 设置 isClosing=true
ScreenshotStage->>JavaFXThread: Platform.runLater 恢复主窗口状态
JavaFXThread-->>ScreenshotStage: 恢复完成
ScreenshotStage->>ScreenshotStage: 设置 isClosing=false
else isClosing=true
ScreenshotStage->>ScreenshotStage: 直接返回
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (9)
🔇 Additional comments (6)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Reviewer's GuideThis pull request addresses an issue with the main window remaining hidden after using screenshot or color picker tools on Mac ARM systems. The fix involves refining the stage closing logic in File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for opening this pull request! |
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @DreamAwakenFateBroke - I've reviewed your changes - here's some feedback:
- This PR disables the window hiding feature on macOS; explore if fixing the hiding mechanism directly on macOS is a viable alternative.
- Platform-specific checks for macOS have been added in multiple places; consider centralizing this logic if more platform-dependent behavior is expected.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
unknowIfGuestInDream
approved these changes
May 5, 2025
This was referenced May 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
enhancement,bug,documentationordependenciesSummary by Sourcery
Fix stage hidden action compatibility issues on Mac Arm architecture
Bug Fixes:
Enhancements:
Summary by CodeRabbit
新功能
修复
优化