Update the EmbreeRaycaster to use embree4 #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustusBraun
force-pushed
the
feature/embree4
branch
from
b07f9b2 to
149f01c
Compare
amock
added a commit
that referenced
this pull request
May 20, 2025
* Fixes for using lvr2 as CMake imported Target and BaseVector matrix multiplication (#34) * Fix cmake warning in find_package_handle_standard_args * Fix compilation with PCL and for using lvr2 targets * Fix PointBuffer constructor would set points as normal data * Fix matrix multiplication with Eigen::Matrix4 indexing * Fix race condition in NearestCenterOctreeReduction * Update the EmbreeRaycaster to use embree4 (#35) * Upgrade Embree support from 3 to 4 * Remove unsupported ubuntu 20.04 and add libembree-dev to dependencies --------- Co-authored-by: Justus Braun <45860849+JustusBraun@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the EmbreeRaycaster algorithm to use embree4 which was released in February 2023.
It also removes the Ubuntu 20 build because the container is no longer supported by GitHub.