Added support for gcc14 when using CUDA >= 12.8 and fixed compile error on gcc15
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the tests aren't actually testing your changes. However, they seem valid and I checked the compilation on older versions: CUDA 12.0, gcc 13, Ubuntu 24.04. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with
CUDA 12.8,gcc 14can be used and is sometimes required, as some newer systems don't shipgcc 13anymore by default. I've updated your automatic cuda gcc version check for that.There was also an issue with
Logging.hppthat usesuint8_tas the storage type for theLogLevelenum, for which the<cstdint>header was missing.