Skip to content

Remove duplicate settings #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2025
Merged

Remove duplicate settings #238

merged 2 commits into from
Aug 16, 2025

Conversation

tristancorbellari
Copy link
Contributor

🛠️ Fixes Issue

Closes #235

👨‍💻 Changes proposed

  • Removed the "Border Cost" and "Border Penalty" settings from duplication in "General Settings", so that they only live in "Extra Settings" now. If "General Settings" is a better place for them to live, I'll be happy to move them there instead.
  • Corrected some inconsistent capitalisation and spelling mistakes ("penality" 🤪)

📄 Note to reviewers

📷 Screenshots

@tristancorbellari
Copy link
Contributor Author

I don't have secrets set up on this fork which I believe is why the workflow is failing

@nilsnolde
Copy link
Member

yeah sadly.. apparently it's possible: https://michaelheap.com/access-secrets-from-forks/. I'll give that a shot sometime. thanks for the cleanup!

@nilsnolde nilsnolde merged commit 5efd21e into valhalla:master Aug 16, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsnolde nilsnolde nilsnolde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate settings border cost and border penalty
2 participants
@tristancorbellari @nilsnolde