refactor: support direct rule evaluation #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
dosubot
bot
added
size:L
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #225 +/- ##
==========================================
- Coverage 66.48% 65.81% -0.68%
==========================================
Files 9 10 +1
Lines 561 550 -11
==========================================
- Hits 373 362 -11
- Misses 175 176 +1
+ Partials 13 12 -1
Continue to review full report in Codecov by Sentry.
|
TylerGillson
added a commit
that referenced
this pull request
Aug 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.15](v0.0.14...v0.0.15) (2024-08-06) ### Other * add hook to install validator crds in devspace ([#221](#221)) ([8982a0d](8982a0d)) * remove unused helm value ([#223](#223)) ([1651b8e](1651b8e)) ### Docs * principal ID and rules in readme ([#222](#222)) ([db29a62](db29a62)) ### Dependency Updates * **deps:** update module github.com/onsi/gomega to v1.34.1 ([#217](#217)) ([4c5d239](4c5d239)) * **deps:** update module github.com/validator-labs/validator to v0.0.51 ([#216](#216)) ([be40010](be40010)) * **deps:** update module github.com/validator-labs/validator to v0.1.0 ([#220](#220)) ([57205c6](57205c6)) ### Refactoring * return error from validate, accept context ([#226](#226)) ([58989c0](58989c0)) * support direct rule evaluation ([#225](#225)) ([bec4a0b](bec4a0b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
Refactor to support direct, in-process evaluation of Azure rules.
Required by:
validator check --directvalidatorctl#102