Optimize product page route shell #1455
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked on #1454
Due to the product pages using the
ProductProvider
, which usesuseSearchParams
, the product route shells are currently pretty much empty. This PR attempts to sketch out how we could push theuseSearchParams
further down, and use it more granularly, so that skeletons can be used as suspense fallbacks wherever product selections can be made that influence the search params. Thus allowing us to statically prerender most of the product details into the route shell. The selection elements then become interactive on hydration. There's still some minor CLS that should be fixed, but it's a start.