Add headers middleware and implement header rules parsing #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjoerdbeentjes
commented
Jul 9, 2025
sjoerdbeentjes
commented
- Introduced a new middleware to apply headers from the _headers file to dynamic responses.
- Implemented header rules parsing logic to support global and specific headers, including placeholder substitution.
- Added tests to ensure correct application of headers based on defined rules.
- Introduced a new middleware to apply headers from the _headers file to dynamic responses. - Implemented header rules parsing logic to support global and specific headers, including placeholder substitution. - Added tests to ensure correct application of headers based on defined rules.
Deploying dda-website with
|
| Latest commit: |
3ec0258
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f15910a7.dda-website.pages.dev |
| Branch Preview URL: | https://dynamic-page-headers.dda-website.pages.dev |
- Replace file system read with direct import of _headers content for improved performance and simplicity. - Remove unnecessary file path handling in the header parsing function.
- Changed the mock implementation in headers.test.ts to use a raw import of the _headers content instead of mocking the fs module. - This adjustment simplifies the test setup and aligns with recent refactoring of header parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.