fix(app-admin): call onClose callback when dialog is closed #4694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The useDialogs hook was not triggering the onClose callback when dialogs were dismissed. The closeDialog function in DialogsContext only removed the dialog from state without executing the user-provided onClose callback.
This fix retrieves the dialog from state before removal and calls the onClose callback if it exists, ensuring proper cleanup and event handling when dialogs are closed through any method (cancel button, accept button, or programmatic closure).
How Has This Been Tested?
I tested it manually using this code example.